You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is an issue with having the NodeType hold the CLI config values. The reason is that ValueEnum is made for unit-type enums, and implementing ValueEnum is possible but makes the CLI very messy. Here is a stackoverflow thread about the same thing. We can do two things if we want this to work:
Get rid of the CLI arguments that are not the key or the config file
Have a different NodeType for config vs CLI argument, where the latter stays a unit-type enum. This would also mean having 2 different config structs (currently we deserialise to ConfigurationArgs if it is TOML or YAML).
I feel that we could turn this abstraction around and make the
NodeType
contain the necessary state for the respective node type.This would make weird configs unrepresentable and avoid the
Option<PeerId>
Originally posted by @jmg-duarte in #666 (comment)
The text was updated successfully, but these errors were encountered: