Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PayPal Checkout improvements #205

Open
kurund opened this issue Jul 8, 2021 · 3 comments
Open

PayPal Checkout improvements #205

kurund opened this issue Jul 8, 2021 · 3 comments

Comments

@kurund
Copy link
Contributor

kurund commented Jul 8, 2021

Current behavior

When one clicks on PayPal checkout button it adds an overlay on CiviCRM page and opens new window to collect the payment and other information.

The popup window closes after submission and it quickly removes overlay on CiviCRM page while the form is being redirected to confirmation or thank you page.

During this period there is slight delay and it might prompt user to click the PayPal button again.

Expected behavior

  • May be we should have a overlay till the form is redirected so that user can't click on any buttons
@eileenmcnaughton
Copy link
Owner

@kurund I think that is all coming from the paypal js - ie the js we include from paypal as opposed to stuff we bundle

@mattwire
Copy link
Contributor

mattwire commented Jul 9, 2021

@kurund Did you see #166 ? It may not fix this issue and is probably not a "merge-ready" solution because it introduces a dependency on the paymentshared/mjwshared library. From my experience developing Stripe and other js-based payments (eg. see new https://lab.civicrm.org/extensions/globalpayments) the only sensible solution here is to have a shared javascript payment library such as CRM.payment that I have created - https://lab.civicrm.org/extensions/mjwshared/-/blob/1.1/js/crm.payment.js - you can see that is now at over 500 lines of code and provides a wide-range of helper functions to ensure js based processors work in all environments.

@michaelmcandrew
Copy link
Contributor

thanks @mattwire - this looks useful. we'll take a look when we come back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants