Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics version and buildDate appear to be redundant #36

Open
olizilla opened this issue Jul 5, 2023 · 0 comments
Open

metrics version and buildDate appear to be redundant #36

olizilla opened this issue Jul 5, 2023 · 0 comments

Comments

@olizilla
Copy link

olizilla commented Jul 5, 2023

We are setting version and buildDate properties manually in metrics.yml. The values are extracted and saved as this.version in the Telemetry instance, but it's never used.

https://github.com/elastic-ipfs/core-lib/blob/314c1ebce6566f7b3f996b7998a38ed9b508759c/src/telemetry.js#L25-L29

They are also set to arbitrary values that do not correspond to the package.version field or the docker image build date tag

We need to identify it these are actually used for anything anywhere, or remove them, as they are a source of confusion. The word on the street is you have to update them to get your metrics to show up. There is no evidence in the codebase I can find to support this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant