Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka: remove messaging.kafka.connect_errors.count metric #481

Open
endorama opened this issue May 23, 2024 · 2 comments
Open

kafka: remove messaging.kafka.connect_errors.count metric #481

endorama opened this issue May 23, 2024 · 2 comments

Comments

@endorama
Copy link
Member

In #479 we introduced separate dimensions on messaging.kafka.connects.count to track successes and failures for connections to Kafka.

To prevent a breaking change we did not remove messaging.kafka.connect_errors.count, the metric we inherited from franz-go kotel plugin, with the plan to remove it at a later moment.

This issue is here to keep track of its removal.

@simitt
Copy link
Contributor

simitt commented May 24, 2024

@endorama how long do we need to keep the messaging.kafka.connect_errors.count metric ?

@endorama
Copy link
Member Author

I identified an issue with using KQL filters in alerts that could force us to use 2 metrics until it's fixed. At the moment we can say that this metric cannot be removed safely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants