From ce14983f6d48eb3f98f46ea7536a97419565a221 Mon Sep 17 00:00:00 2001 From: David Luna Date: Tue, 18 Jul 2023 10:25:33 +0200 Subject: [PATCH 1/3] docs: add some OTel attributes for DynamoDB spec --- specs/agents/tracing-instrumentation-db.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/specs/agents/tracing-instrumentation-db.md b/specs/agents/tracing-instrumentation-db.md index 837aa832..94393a5a 100644 --- a/specs/agents/tracing-instrumentation-db.md +++ b/specs/agents/tracing-instrumentation-db.md @@ -69,6 +69,10 @@ The following fields are relevant for database and datastore spans. Where possib | __**service.target._**__ |
|
| |`_.type`| `dynamodb` || |`_.name`| e.g. `us-east-1` | Use same value as `context.db.instance` | +| __**otel.attributes._**__ |
|
| +TODO +|`_["aws.dynamodb.table_names"]`| `[ MyTable ]` | The table names, if available. See [OTel Semantic Conventions](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.23.0/specification/trace/semantic_conventions/instrumentation/aws-sdk.md). Note: this must be a single dotted string key in the `otel.attributes` mapping -- for example `{"otel": {"attributes": {"aws.dynamodb.table_names": "[ MyTable ]"}}}` -- and *not* a nested object. | +|`_["aws.dynamodb.projection"]`| `Field1, Field2` | The value of the `ProjectionExpression` request parameter, if available. See [OTel Semantic Conventions](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.23.0/specification/trace/semantic_conventions/instrumentation/aws-sdk.md). Note: this must be a single dotted string key in the `otel.attributes` mapping -- for example `{"otel": {"attributes": {"aws.dynamodb.projection": "Field1, Field2"}}}` -- and *not* a nested object. | ### AWS S3 From d82ccda2bf6b46c5b9d9ab4a13f9b635930d3bef Mon Sep 17 00:00:00 2001 From: David Luna Date: Tue, 18 Jul 2023 15:21:38 +0200 Subject: [PATCH 2/3] chore: remove TODO mark --- specs/agents/tracing-instrumentation-db.md | 1 - 1 file changed, 1 deletion(-) diff --git a/specs/agents/tracing-instrumentation-db.md b/specs/agents/tracing-instrumentation-db.md index 94393a5a..7f9af671 100644 --- a/specs/agents/tracing-instrumentation-db.md +++ b/specs/agents/tracing-instrumentation-db.md @@ -70,7 +70,6 @@ The following fields are relevant for database and datastore spans. Where possib |`_.type`| `dynamodb` || |`_.name`| e.g. `us-east-1` | Use same value as `context.db.instance` | | __**otel.attributes._**__ |
|
| -TODO |`_["aws.dynamodb.table_names"]`| `[ MyTable ]` | The table names, if available. See [OTel Semantic Conventions](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.23.0/specification/trace/semantic_conventions/instrumentation/aws-sdk.md). Note: this must be a single dotted string key in the `otel.attributes` mapping -- for example `{"otel": {"attributes": {"aws.dynamodb.table_names": "[ MyTable ]"}}}` -- and *not* a nested object. | |`_["aws.dynamodb.projection"]`| `Field1, Field2` | The value of the `ProjectionExpression` request parameter, if available. See [OTel Semantic Conventions](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.23.0/specification/trace/semantic_conventions/instrumentation/aws-sdk.md). Note: this must be a single dotted string key in the `otel.attributes` mapping -- for example `{"otel": {"attributes": {"aws.dynamodb.projection": "Field1, Field2"}}}` -- and *not* a nested object. | From cf9098093ed7b6ecd281703f1133bc0785080f05 Mon Sep 17 00:00:00 2001 From: David Luna Date: Wed, 19 Jul 2023 09:48:04 +0200 Subject: [PATCH 3/3] chore: fix format on table_list spec --- specs/agents/tracing-instrumentation-db.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specs/agents/tracing-instrumentation-db.md b/specs/agents/tracing-instrumentation-db.md index 7f9af671..ec46b0e8 100644 --- a/specs/agents/tracing-instrumentation-db.md +++ b/specs/agents/tracing-instrumentation-db.md @@ -70,7 +70,7 @@ The following fields are relevant for database and datastore spans. Where possib |`_.type`| `dynamodb` || |`_.name`| e.g. `us-east-1` | Use same value as `context.db.instance` | | __**otel.attributes._**__ |
|
| -|`_["aws.dynamodb.table_names"]`| `[ MyTable ]` | The table names, if available. See [OTel Semantic Conventions](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.23.0/specification/trace/semantic_conventions/instrumentation/aws-sdk.md). Note: this must be a single dotted string key in the `otel.attributes` mapping -- for example `{"otel": {"attributes": {"aws.dynamodb.table_names": "[ MyTable ]"}}}` -- and *not* a nested object. | +|`_["aws.dynamodb.table_names"]`| `[ MyTable ]` | The table names, if available. See [OTel Semantic Conventions](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.23.0/specification/trace/semantic_conventions/instrumentation/aws-sdk.md). Note: this must be a single dotted string key in the `otel.attributes` mapping -- for example `{"otel": {"attributes": {"aws.dynamodb.table_names": [ MyTable ]}}}` -- and *not* a nested object. | |`_["aws.dynamodb.projection"]`| `Field1, Field2` | The value of the `ProjectionExpression` request parameter, if available. See [OTel Semantic Conventions](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.23.0/specification/trace/semantic_conventions/instrumentation/aws-sdk.md). Note: this must be a single dotted string key in the `otel.attributes` mapping -- for example `{"otel": {"attributes": {"aws.dynamodb.projection": "Field1, Field2"}}}` -- and *not* a nested object. | ### AWS S3