Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect failures in CSP inputs and metricsets #39505

Open
1 of 2 tasks
zmoog opened this issue May 10, 2024 · 3 comments
Open
1 of 2 tasks

Detect failures in CSP inputs and metricsets #39505

zmoog opened this issue May 10, 2024 · 3 comments
Assignees
Labels
enhancement Team:obs-ds-hosted-services Label for the Observability Hosted Services team

Comments

@zmoog
Copy link
Contributor

zmoog commented May 10, 2024

Situation

2 weeks ago, a simple version bump of the core aws-sdk-go-v2 module to 1.26.1 put the AWS SDK module versions mix in an inconsistent state, causing error in multiple AWS inputs and metricsets.

We are addressing this specific error at #39454

Problem Statement

While we could consider this an edge case, the current suite did not catch the dependency problem.

We should probably:

  • Understand why the test suite did not catch the dependency problem.
  • Set up mechanisms to avoid similar problems in the future
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 10, 2024
@zmoog
Copy link
Contributor Author

zmoog commented May 10, 2024

To improve dependency management, we're setting up Dependabot to handle SDK dependency updates for all major CSPs. See #39492 for more.

@ycombinator ycombinator added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label May 15, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 15, 2024
@zmoog
Copy link
Contributor Author

zmoog commented Jul 22, 2024

Understand why the test suite did not catch the dependency problem.

We didn't catch the dependency problem because the PR introducing the new dependency didn't have the aws label.

The CI runs the AWS integration tests suite only if the PR has the aws label.

@zmoog zmoog self-assigned this Jul 22, 2024
@zmoog zmoog changed the title Detect failures in CSP inputs and meticsets Detect failures in CSP inputs and metricsets Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

No branches or pull requests

3 participants