-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation freeze: github action PR's #281
Comments
@reakaleek might have pre-made tooling from the robots team to handle this? I think I've seen something from Victor in the past? |
FYI, I verified that the code snippet works at https://github.com/elastic/docs-eng-playground/pull/4 |
But I'm wondering if the check should fail? |
Yup. We were using https://github.com/elastic/gh-oblt which has the We only had it because we had changes to multiple repos quite frequently and it can handle complex changes. This is a rather simple use case. I can definitely do it. But I don't think it's worth it, if you are not familiar with the tool. TL;DR I can take over this if you like to. But I imagine a one off script is perfectly fine in this case too. |
I had to re-run the script and replace Otherwise, the workflow will fail to comment on PRs from forks. |
## Details⚠️ This PR was created by an automated tool. Please review the changes carefully.⚠️ Add a workflow that will comment on PRs with AsciiDoc changes. ## Why During the migration to Elastic Docs v3, the Docs team will focus exclusively on migrating content. To maintain consistency, prevent conflicts, and ensure a smoother transition we will freeze all AsciiDoc changes. This means you will get a warning when you create AsciiDoc changes in your PRs. See elastic/docs-builder#281 for details If there are any questions, please reach out to the @elastic/docs-engineering --------- Co-authored-by: Brandon Morelli <[email protected]>
For the documentation freeze we need to ensure the following repositories have the documentation freeze github action set up.
This action only comments making everyone aware of the freeze. It won't block PR's from being merged
See: https://elastic.github.io/docs-builder/migration/freeze/gh-action.html
This meta ticket exists as a way to track all the repositories currently publishing in V1.
The PR's will be opened through a one off script to all of these.
External
The text was updated successfully, but these errors were encountered: