Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable annotations on doc previews #1211

Open
debadair opened this issue Sep 24, 2019 · 0 comments
Open

Enable annotations on doc previews #1211

debadair opened this issue Sep 24, 2019 · 0 comments
Labels
defer enhancement Something we'd like to improve feedback Getting feedback and contributions via the documentation preview About the preview service canonically hosted on docs-preview.app.elstc.co

Comments

@debadair
Copy link
Contributor

Now that we have previews, @kellyemurphy pointed out that it would be nice to enable people to comment directly from the rendered docs instead of from the GitHub diff. Something like http://annotatorjs.org/ might be a way to enable that.

It's important that all comments are fed back into the PR in GitHub, though. (Trying to keep track of and reconcile different comment streams is crazy-making.)

Relates to ##336
@debadair debadair added the enhancement Something we'd like to improve label Sep 24, 2019
@debadair debadair mentioned this issue Sep 24, 2019
Closed
36 tasks
@gtback gtback added preview About the preview service canonically hosted on docs-preview.app.elstc.co feedback Getting feedback and contributions via the documentation labels May 14, 2020
@gtback gtback added the defer label Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defer enhancement Something we'd like to improve feedback Getting feedback and contributions via the documentation preview About the preview service canonically hosted on docs-preview.app.elstc.co
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@debadair @gtback