Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an upgrade integration test to confirm upgrades can succeed when a binary download proxy is configured #4322

Open
cmacknz opened this issue Feb 22, 2024 · 1 comment
Labels
Team:Elastic-Agent Label for the Agent team

Comments

@cmacknz
Copy link
Member

cmacknz commented Feb 22, 2024

Relates:

We have unit tests covering the underlying functionality now that #4241 is resolved, but in the process of fixing that issue we uncovered another problem with the fallback GPG URL using the wrong proxy in #4241

We need to add an integration test that confirms an upgrade can succeed when a binary download proxy is configured. We should have all the building blocks to do this since we already have tests that ensure Fleet proxy configuration works correctly. https://github.com/elastic/elastic-agent/blob/main/testing/integration/proxy_url_test.go

We need to extend those tests to cover the proxy for the upgrade download URL. That proxy URL was not respected for signature verification and this problem was able to hide in the code for a long time because this test is missing.

@cmacknz cmacknz added the Team:Elastic-Agent Label for the Agent team label Feb 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

No branches or pull requests

2 participants