Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive auto logMinLimit value #2400

Open
nickofthyme opened this issue Apr 9, 2024 · 0 comments
Open

Derive auto logMinLimit value #2400

nickofthyme opened this issue Apr 9, 2024 · 0 comments
Labels
:data Data/series/scales related issue :xy Bar/Line/Area chart related

Comments

@nickofthyme
Copy link
Collaborator

In #916 we added the option of logMinLimit to remove the hardcoded value of 1 add the lower bound of a logarithmic scale.

Ideally, we can determine this value automatically and set the lower bound of the scale to the lower bound of the data.

The solution here is to keep the logMinLimit option and use it if defined, if not we compute it given the data. If the value is indeterminate we could use 1 as a default.

This value also applies to the determination of the baseline of the logarithmic scale for area and bar chart which is defaulted to a value of 1. In this case we should compute the min value and clamp if below 1, this value could also be configurable as logMaxLimit.

@nickofthyme nickofthyme added :data Data/series/scales related issue :xy Bar/Line/Area chart related labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:data Data/series/scales related issue :xy Bar/Line/Area chart related
Projects
None yet
Development

No branches or pull requests

1 participant