Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchServiceTests.testParseSourceValidation fails #115936

Open
benwtrent opened this issue Oct 30, 2024 · 2 comments
Open

SearchServiceTests.testParseSourceValidation fails #115936

benwtrent opened this issue Oct 30, 2024 · 2 comments
Assignees
@carlosdelest
Labels
low-risk An open issue or test failure that is a low risk to future releases :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test-failure Triaged test failures from CI

Comments

@benwtrent
Copy link
Member

CI Link

https://gradle-enterprise.elastic.co/s/kwj5ep3e5vymm

Repro line

./gradlew ":server:test" --tests "org.elasticsearch.search.SearchServiceTests.testParseSourceValidation" -Dtests.seed=DB172D57BA3537A5 -Dtests.locale=ar-BH -Dtests.timezone=America/Argentina/San_Luis -Druntime.java=22

Does it reproduce?

Yes

Applicable branches

main

Failure history

No response

Failure excerpt

SearchServiceTests > testParseSourceValidation FAILED
    java.lang.AssertionError:
    Expected: a string containing "`search_after` cannot be used in a scroll context."
         but: was "Sort must contain at least one field."
        at __randomizedtesting.SeedInfo.seed([DB172D57BA3537A5:48807AB8AFE2159C]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
        at org.elasticsearch.test.ESTestCase.assertThat(ESTestCase.java:2543)
        at org.elasticsearch.search.SearchServiceTests.assertCreateContextValidation(SearchServiceTests.java:3038)
        at org.elasticsearch.search.SearchServiceTests.testParseSourceValidation(SearchServiceTests.java:2947)
@benwtrent benwtrent added :Search/Search Search-related issues that do not fall into other categories >test-failure Triaged test failures from CI needs:triage Requires assignment of a team area label labels Oct 30, 2024
@elasticsearchmachine elasticsearchmachine added Team:Search Meta label for search team needs:risk Requires assignment of a risk label (low, medium, blocker) labels Oct 30, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Oct 30, 2024
@carlosdelest carlosdelest self-assigned this Oct 30, 2024
@carlosdelest carlosdelest added low-risk An open issue or test failure that is a low risk to future releases and removed needs:risk Requires assignment of a risk label (low, medium, blocker) labels Oct 30, 2024
@carlosdelest
Copy link
Member

Marking low-risk, the test was muted and then the checking order changed for the request, so now the response is a different message.

It is still an IllegalArgumentException with a different message, so users would receive a 400 back in case this is not a testing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlosdelest carlosdelest

Labels
low-risk An open issue or test failure that is a low risk to future releases :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benwtrent @carlosdelest @elasticsearchmachine