We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go-ucfg's Unpack method calls InitDefaults on the passed item along with any of it's children that implement the function.
Unpack
InitDefaults
However we explicity call the children's InitDefaults from the parent:
fleet-server/internal/pkg/config/input.go
Lines 155 to 160 in 0718a55
Lines 96 to 109 in 0718a55
These extra InitDefaults calls are not needed; the input's InitDefaults can probably be reduced to
func (c *Input) InitDefaults() { c.Type = fleetInputType }
and most other structs in our config package can be redone as well. We should try to clean this up to reduce extra calls.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
go-ucfg's
Unpack
method callsInitDefaults
on the passed item along with any of it's children that implement the function.However we explicity call the children's
InitDefaults
from the parent:fleet-server/internal/pkg/config/input.go
Lines 155 to 160 in 0718a55
and this continues for a few extra layers:
fleet-server/internal/pkg/config/input.go
Lines 96 to 109 in 0718a55
These extra
InitDefaults
calls are not needed; the input'sInitDefaults
can probably be reduced toand most other structs in our config package can be redone as well.
We should try to clean this up to reduce extra calls.
The text was updated successfully, but these errors were encountered: