Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet server standalone crash on startup if es return 429 #3205

Closed
nchaulet opened this issue Jan 4, 2024 · 3 comments · Fixed by #3232
Closed

Fleet server standalone crash on startup if es return 429 #3205

nchaulet opened this issue Jan 4, 2024 · 3 comments · Fixed by #3232
Assignees
Labels
bug Something isn't working Project:Serverless Team:Fleet Label for the Fleet team

Comments

@nchaulet
Copy link
Member

nchaulet commented Jan 4, 2024

Description

It seems Fleet server standalone crash during startup if elasticsearch return a 429 (could happen in serverless if the proxy refuse the connetion)

It's probably something we should handle, and recover from.

Screenshot 2024-01-04 at 4 42 32 PM
@nchaulet nchaulet added bug Something isn't working Team:Fleet Label for the Fleet team Project:Serverless labels Jan 4, 2024
@michel-laterman michel-laterman self-assigned this Jan 22, 2024
@michel-laterman
Copy link
Contributor

@nchaulet, I've added e2e tests for a 429 response (and timeout) from ES when fleet-server initializes, but have not reproduced the crash. Do we know anything else about what caused the issue?

@nchaulet
Copy link
Member Author

@nchaulet, I've added e2e tests for a 429 response (and timeout) from ES when fleet-server initializes, but have not reproduced the crash. Do we know anything else about what caused the issue?

No other than the logs there was nothing else, (it seems it only happens one time, so we may want to close this and re-open if this happen more frequently)

@michel-laterman
Copy link
Contributor

Sounds good, I think we should get the e2e tests merged too so we can make sure we don't introduce a regression that causes this more often

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Project:Serverless Team:Fleet Label for the Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants