Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logs consistency #3239

Closed
michel-laterman opened this issue Jan 29, 2024 · 3 comments · Fixed by #3247
Closed

logs consistency #3239

michel-laterman opened this issue Jan 29, 2024 · 3 comments · Fixed by #3247
Assignees
Labels
Team:Fleet Label for the Fleet team tech debt

Comments

@michel-laterman
Copy link
Contributor

fleet-server has log lines with inconsistent attributes.

For example:

Str("fleet.policy.output.name", p.Name).Logger()

logger.Error().Err(err).Str("outputName", outputName).Msg(doc.Message)

Both refer to policy outputs but are named different things.
We should go through the codebase and try to make these more consistent (following ecs)

@juliaElastic
Copy link
Contributor

Few more places to make consistent:
The action type is logged under different fields:

ack event
actionId

Action delivered to agent on checkin
id

Found that the policy id is also logged under different names:

New revision of policy received and added to the queue
fleet.policy.id

Policy coordinator added a new policy revision
policy_id

@juliaElastic
Copy link
Contributor

Revision_idx fields are changed in this pr #3234

@juliaElastic
Copy link
Contributor

Found one more place where revision and coordinator idx is logged under a different name:

Int64("fleet.policyRevision", pp.Policy.RevisionIdx).
Int64("fleet.policyCoordinator", pp.Policy.CoordinatorIdx).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Label for the Fleet team tech debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants