Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace dsl with go-elasticsearch typed API #3831

Open
michel-laterman opened this issue Aug 21, 2024 · 1 comment
Open

replace dsl with go-elasticsearch typed API #3831

michel-laterman opened this issue Aug 21, 2024 · 1 comment
Labels
good first issue Good for newcomers Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team tech debt

Comments

@michel-laterman
Copy link
Contributor

fleet-server implements a DSL for some interactions with Elasticsearch.
The DSL is not complete and has poor test coverage, it's usage should be replaced by the offical go-elasticsearch typed API
@michel-laterman michel-laterman added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team tech debt labels Aug 21, 2024
@ycombinator ycombinator added the good first issue Good for newcomers label Aug 22, 2024
@scunningham
Copy link

Hmm, is it working? Does it have issues? Seems like replacing for the sake of replacing. Enjoy.

If I recall the client didn't have a query builder of any sort. Perhaps that's changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ycombinator @scunningham @michel-laterman