From 6630153159345bc043d1adbb25d9259818b47a13 Mon Sep 17 00:00:00 2001 From: PhilippeOberti Date: Tue, 22 Oct 2024 16:36:55 -0500 Subject: [PATCH] PR comments --- .../components/header_actions/add_note_icon_item.tsx | 2 +- .../public/notes/components/search_row.tsx | 10 +++++----- .../tabs/query/query_tab_unified_components.test.tsx | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/x-pack/plugins/security_solution/public/common/components/header_actions/add_note_icon_item.tsx b/x-pack/plugins/security_solution/public/common/components/header_actions/add_note_icon_item.tsx index b09ec8b01de83..f931042863a62 100644 --- a/x-pack/plugins/security_solution/public/common/components/header_actions/add_note_icon_item.tsx +++ b/x-pack/plugins/security_solution/public/common/components/header_actions/add_note_icon_item.tsx @@ -15,7 +15,7 @@ import { ActionIconItem } from './action_icon_item'; const NOTES_DISABLE_TOOLTIP = i18n.translate( 'xpack.securitySolution.timeline.body.notes.disableEventTooltip', { - defaultMessage: 'Notes may not be added here while editing a template timeline', + defaultMessage: 'Notes cannot be added here while editing a template Timeline.', } ); const NOTES_ADD_TOOLTIP = i18n.translate( diff --git a/x-pack/plugins/security_solution/public/notes/components/search_row.tsx b/x-pack/plugins/security_solution/public/notes/components/search_row.tsx index b4111a765b078..3c4093f913acf 100644 --- a/x-pack/plugins/security_solution/public/notes/components/search_row.tsx +++ b/x-pack/plugins/security_solution/public/notes/components/search_row.tsx @@ -31,14 +31,14 @@ const searchBox = { 'data-test-subj': SEARCH_BAR_TEST_ID, }; const associatedNoteSelectOptions: EuiSelectOption[] = [ - { value: AssociatedFilter.all, text: 'All notes' }, - { value: AssociatedFilter.documentOnly, text: 'Attached to alerts/events only' }, - { value: AssociatedFilter.savedObjectOnly, text: 'Attached to Timelines only' }, + { value: AssociatedFilter.all, text: 'Anything or nothing' }, + { value: AssociatedFilter.documentOnly, text: 'Alerts or events only' }, + { value: AssociatedFilter.savedObjectOnly, text: 'Timelines only' }, { value: AssociatedFilter.documentAndSavedObject, - text: 'Attached to alerts/events and Timelines only', + text: 'Alerts or events and Timelines only', }, - { value: AssociatedFilter.orphan, text: 'Unattached notes' }, + { value: AssociatedFilter.orphan, text: 'Nothing' }, ]; export const SearchRow = React.memo(() => { diff --git a/x-pack/plugins/security_solution/public/timelines/components/timeline/tabs/query/query_tab_unified_components.test.tsx b/x-pack/plugins/security_solution/public/timelines/components/timeline/tabs/query/query_tab_unified_components.test.tsx index e14b128a8209a..107c166183647 100644 --- a/x-pack/plugins/security_solution/public/timelines/components/timeline/tabs/query/query_tab_unified_components.test.tsx +++ b/x-pack/plugins/security_solution/public/timelines/components/timeline/tabs/query/query_tab_unified_components.test.tsx @@ -918,7 +918,7 @@ describe('query tab with unified timeline', () => { await waitFor(() => { expect(screen.getByTestId('timeline-notes-tool-tip')).toBeInTheDocument(); expect(screen.getByTestId('timeline-notes-tool-tip')).toHaveTextContent( - '1 note available. Click to view it & add more.' + '1 note available. Click to view it and add more.' ); }); }, @@ -975,7 +975,7 @@ describe('query tab with unified timeline', () => { await waitFor(() => { expect(screen.getByTestId('timeline-notes-tool-tip')).toBeVisible(); expect(screen.getByTestId('timeline-notes-tool-tip')).toHaveTextContent( - '1 note available. Click to view it & add more.' + '1 note available. Click to view it and add more.' ); }); },