Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting] Restore the PDF layer for 6.2 URL compatibility #108118

Closed
tsullivan opened this issue Aug 10, 2021 · 3 comments · Fixed by #108271
Closed

[Reporting] Restore the PDF layer for 6.2 URL compatibility #108118

tsullivan opened this issue Aug 10, 2021 · 3 comments · Fixed by #108271
Labels
blocker bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort v8.0.0

Comments

@tsullivan
Copy link
Member

tsullivan commented Aug 10, 2021 •
edited
Loading

Refers to: #105868 (comment)

The PDF compatibility shim that provides support for POST URLs that were copied in v6.2 and lower needs unique telemetry. Teams must know if legacy features are still in use before code can be deleted.

Blocker: Currently, the master branch does not have the compatibility shim file for PDF job creation, from thinking that it would be OK to stop supporting 6.2 compatibility in 8.0. That shim file needs to be restored in the master branch, on the assumption that compatibility DOES need to keep being supported in 8.0.

This will effectively revert fef8485
@tsullivan tsullivan added bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:AppServices labels Aug 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@tsullivan tsullivan mentioned this issue Aug 10, 2021
Closed
@tsullivan tsullivan changed the title [Reporting] The PDF layer for 6.2 URL compatibility needs metadata and telemetry [Reporting] Restore the PDF layer for 6.2 URL compatibility Aug 10, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort labels Aug 11, 2021
@tsullivan
Copy link
Member Author

Depends on #108140

@tsullivan tsullivan mentioned this issue Aug 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Reporting] Restore legacy compatibility shim for PDF job creation tsullivan/kibana
2 participants
@tsullivan @elasticmachine