Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Use SessionStorage to Persist ViewMode State #108920

Closed
ThomThomson opened this issue Aug 17, 2021 · 1 comment · Fixed by #112302
Closed

[Dashboard] Use SessionStorage to Persist ViewMode State #108920

ThomThomson opened this issue Aug 17, 2021 · 1 comment · Fixed by #112302
Labels
Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

App State Removed from URL

In 7.x, #86939 & #97941 removed all dashboard app state from the URL. This allows for a cleaner developer experience, shorter URLs for the user, and the ability to use by value panels in dashboards, but unfortunately results in some changes to the user experience.

Session Storage

A potential pitfall with removing app state from the URL was that the dashboard editing experience could become frustrating because reloading the page or leaving the dashboard app could potentially delete unsaved changes that the user has made. To mitigate this, we created a system which stores unsaved edits in the browser session storage, with the dashboardId as a key.

What about View Mode?

The session storage system only works when the user enters edit mode. This means that any filters or query changes that the user makes in View Mode will not persist over reloads, or over navigations. The session storage system could be extended to store these changes as well for a more consistent experience.

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Aug 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants