-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Meta] 8.0 Kibana deprecations #109166
Comments
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
Deprecations in the UIHere's how a deprecation retrieved from the API will be surfaced in the UI. Note that support for "title" is currently blocked on #99625. |
Multiple Data Paths will be deprecated too apparently... Might be sth worth adding. |
@elastic/kibana-gis deprecations listed with upgrade assistant |
We don't have enough good reasoning to completely remove this, which would mean removing support for Still though, we'd like to log deprecations that support will be removed "in a future version" to motivate users to change their config as early as possible. cc @elastic/kibana-reporting-services @vadimkibana |
@cjcenizal I've added a details FAQ for deprecations service with examples and a more tailored copy-writing guidelines based on the google doc. https://github.com/elastic/kibana/tree/master/src/core/server/deprecations#writing-deprecation-details I believe it makes more sense to link it here rather than the google doc as it contains notes about using the service, i18n, and all the best practices we have |
Looks like everything that's been noted here has been addressed, with the possible exception of some items on the Security team's meta issue (#111160). Thanks for everyone's hard work on this! |
We'll use this issue to track 8.0 Kibana deprecations, to ensure a smooth 8.0 upgrade experience.
Example
For an example PR of how to design and register a deprecation, please see #110960. This deprecation is awesome because it:
Creating deprecations
Target 7.x
When creating a deprecation, target the 7.x branch with your PR. Upgrade Assistant is enabled for 7.16, but continues to be disabled for 8.0. UA is currently designed solely for major upgrades, not upgrades between minors.
Use the Core Deprecations API
The Core Deprecations API is the engine that drives Upgrade Assistant's Kibana-specific functionality. For questions, reach out to @elastic/kibana-core.
Write great copy
@debadair and @gchaps have created copywriting guidelines how to write good copy for your deprecations. Please consult them with questions.
Include relevant links
Provide links to docs wherever possible.
Specify the correct
level
Deprecations with
level: 'critical'
will block the upgrade until they're addressed. Deprecations withlevel: 'warning'
will not.Add steps for testing to your PR
This helps the Stack Management and QA teams double-check the UX and ensure the new UA features work well with your deprecation.
Add screenshots of how the deprecation appears in UA to your PR
Same as above.
Test your deprecation in Upgrade Assistant
This goes without saying, but please open Upgrade Assistant and follow your steps for testing yourself. Please also test your remediation steps to identify and smooth over any rough edges in this process.
Deprecations list
Alerting
@elastic/kibana-alerting-services
xpack.task_manager.index
settingAPM
@elastic/apm-ui
Core
@elastic/kibana-core
Operations
@elastic/kibana-operations
Geo
@elastic/kibana-gis
Kibana App
@elastic/kibana-app
[Breaking change] Removal of Timelion app(removed in 7.16)Kibana Presentation
@elastic/kibana-presentation
Kibana App Services
@elastic/kibana-app-services
[Breaking][data.indexPatterns] Remove expression-based scripted fields from Kibana[Breaking change]Reporting: remove reporting_user rolexpack.reporting.index
Monitoring
@elastic/stack-monitoring-ui
[Monitoring] 8.0 Upgrade AssistantSecurity
@elastic/kibana-security Tested with 7.16 ✅
See #111160
Stack Management
@elastic/kibana-stack-management
The text was updated successfully, but these errors were encountered: