Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested dashboard panel groups #12313

Closed
stacey-gammon opened this issue Jun 13, 2017 · 10 comments
Closed

Nested dashboard panel groups #12313

stacey-gammon opened this issue Jun 13, 2017 · 10 comments
Labels

Comments

@stacey-gammon
Copy link
Contributor

With the introduction of more flexible dashboard embeddability - #11741 with PR #12146, we could allow the user to embed dashboards inside dashboards.

If we also introduced the concept of minimizing panels, something like this:
minmaxpanels

Then that would solve #1547 and #11832

@cjcenizal
Copy link
Contributor

cjcenizal commented Jun 13, 2017

image

Though, I'm not sure this will directly address #1547, which I think of more as a fundamental redesign of how we layout panels in a Dashboard (forcing each panel in a row to be the same height and disallowing the "mosaic" layouts we support today).

@cjcenizal
Copy link
Contributor

Also, what happens if there are circular references between dashboards? Dashboard A embeds Dashboard B embeds Dashboard A...

@stacey-gammon
Copy link
Contributor Author

++ @cjcenizal - I meant that the addressing of #11741 is what will support this, not the other way around.

Good point about the circular reference, we'll have to keep that in mind and figure out how to handle/disallow it.

@stacey-gammon
Copy link
Contributor Author

Now that I'm rereading your comment @cjcenizal I think maybe you linked to the wrong issue.

Is that something the design team wants to do? Force all panels in a row to be the same height? Or maybe, if we do want to introduce the concept of rows, we should determine the height by the tallest panel in a row?

If that is a direction we want to go in, then while I still want this issue to stick around, I may change priorities to address the grouping/collapsing request in a different way.

@cjcenizal
Copy link
Contributor

@stacey-gammon Ah I meant to link to #1547. I just updated my comment with the correct link. And I think I may have been off the mark, since we used to have rows in Kibana 4, and then we got rid of them, and now we want to support collapsible groups instead (which could be a collapsible dashboard within another dashboard). @snide Any thoughts on how we want to support this based on your new designs?

@snide
Copy link
Contributor

snide commented Jun 13, 2017

@cjcenizal Talked with @stacey-gammon about this today. Added it to our roadmap and told her I'd get some stuff their way early next week once I get back.

@alexfrancoeur
Copy link

@cjcenizal I can send you a video a customer put together as to why they would like the collapsable grouping of panel "rows". In my opinion, Stacey's proposal here would work as well for this use case. The idea being I don't need all this information at once, let me choose when to expose x,y and z visualizations. While it's a common ask to want the collapsable rows, I think the functionality Stacey proposed fits more with the dynamic sizing and grid placement our dashboard panels currently have. For something like this, I already have a few users in mind to test out the concept with once we have some designs in place.

I'd be interested in seeing how a full dashboard would look / work in this in this scenario. Also, from a technical aspect - would we query for this panel even if it's collapsed? Or wait until it's expanded? In which case, what happens on refresh? Do we keep separate queries per panel or combine into one large query?

@JacobBrandt
Copy link
Contributor

JacobBrandt commented Feb 15, 2018

I like this idea. What about also having a dashboard tab group. Basically a way the user can add dashboards to a tabbed list that lives under the filter bar.

Right now our users have to do a search for each dashboard when they want to switch or keep several tabs open to accomplish this. The worse part is they want the filters they already had applied for each one so they have to set the filters again for each browser tab open or do it all over again when looking at another dashboard.

@stacey-gammon stacey-gammon changed the title Allow nested Dashboards Nested dashboard panel groups Feb 26, 2018
@stacey-gammon
Copy link
Contributor Author

Going to close this in favor of this new issue: #16919. I just want to keep this around for historical reasons, but that new issue lays out the nested dashboard idea in more detail, with some mock ups using some hacked together code.

@stacey-gammon
Copy link
Contributor Author

also @JacobBrandt - we also have a feature request for tabs/pages here #15120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants