Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Display the previous period timestamp on the chart tooltip when comparison is enabled #127306

Open
gbamparop opened this issue Mar 9, 2022 · 9 comments
Open

[APM] Display the previous period timestamp on the chart tooltip when comparison is enabled #127306

gbamparop opened this issue Mar 9, 2022 · 9 comments
Labels
apm:charts enhancement New value added to drive a business result impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:APM All issues that need APM UI Team support

Comments

@gbamparop
Copy link
Contributor

Summary

Currently, only the current period timestamp is displayed on the chart tooltip. It would be great to include the previous period as well as it is not always clear, especially when Period before is selected.

image
@gbamparop gbamparop added Team:APM All issues that need APM UI Team support enhancement New value added to drive a business result apm:charts labels Mar 9, 2022
@markov00 markov00 added the Team:DataVis Team label for DataVis Team label Mar 22, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/datavis (Team:DataVis)

@markov00
Copy link
Member

@gbamparop we are currently working on a tooltip redesign that will cover this requirement.
Can you please explain a bit more the desired outcome, in particular, I'd like to know:

  • how are you offsetting the data (by calendar (start of the week vs start of the week before) or by fixed date (7 days vs 14 days ago).
  • Do you need to show the exact date/time of the previous period, or just what "changed" between the current and the previous( for example just the different date if the hour is the same)

@gbamparop
Copy link
Contributor Author

gbamparop commented Mar 22, 2022 •
edited
Loading

@markov00 that's great to hear!

The offset depends on the selection of the comparison option.

It can be a day / week before or a custom period which is based on the time difference between the current start and end dates (we subtract this difference from both dates to calculate the previous period). In the last case, the year / day / time might be different than the current one so in my opinion it would be good to display the full date of the current / previous period.

cc @formgeist

@markov00
Copy link
Member

cc @gvnmagni

@sorenlouv
Copy link
Member

sorenlouv commented Jun 21, 2022 •
edited
Loading

@markov00 Should this issue be transferred to https://github.com/elastic/elastic-charts or is there already a related issue we can follow and link to from here?

@sorenlouv sorenlouv mentioned this issue Jun 21, 2022
Open
18 tasks
@markov00
Copy link
Member

This is the issue to follow is actually this one elastic/elastic-charts#919

@stratoula stratoula added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Nov 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@stratoula stratoula added Feature:ElasticCharts Issues related to the elastic-charts library and removed Team:DataVis Team label for DataVis Team labels Nov 4, 2022
@stratoula stratoula added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Jan 16, 2023
@sorenlouv
Copy link
Member

This is no longer blocked by Elastic Charts (elastic/elastic-charts#615 (comment)).

@gbamparop It's probably too late to include this in 8.8 but we could add it as a stretch goal or include it in 8.9. WDYT?

@sorenlouv sorenlouv removed Feature:ElasticCharts Issues related to the elastic-charts library Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 31, 2023
@gbamparop
Copy link
Contributor Author

gbamparop commented Feb 2, 2023 •
edited
Loading

That's good news! Let's include it in 8.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
apm:charts enhancement New value added to drive a business result impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:APM All issues that need APM UI Team support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@dannycroft @sorenlouv @markov00 @gbamparop @elasticmachine @stratoula