Kibana displays save and return to dashboard listing page when users click on discover->visualize->lens->save and return

[bhavyarm]

Kibana version: 8.5.0 BC1

Elasticsearch version: 8.5.0 BC1

Server OS version: darwin_x86_64

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: When users navigate to visualize in lens from discover - Kibana displays an active save and return button.
When user clicks on it - kibana takes him to dashboard listing page which is very confusing.

Steps to reproduce:

1. Click on visualize on a field which can be visualized in discover side bar
2. Kibana takes you to lens
3. Click on save and return
4. Kibana drops you to dashboard landing page

save_return.mp4

[elasticmachine]

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

[stratoula]

@bhavyarm I can't replicate it 🤔 Can you give us more details in order to be able to reproduce it? Thanx!

[flash1293]

I can reproduce the issue when doing this:

• Go to dashboard
• Start editing
• Add Lens vis to dashboard
• Leave dashboard
• Go to discover
• Do what the recording in the description shows

The problem is that the EmbeddableStateTransfer is not removed and picked up on the next load of Lens:

kibana/x-pack/plugins/lens/public/app_plugin/mounter.tsx

Line 143 in 205f592

const embeddableEditorIncomingState = stateTransfer?.getIncomingEditorState(APP_ID);

@ThomThomson I'm not 100% sure how it's supposed to work - should we clear the embeddable state transfer for Lens when the user is navigating away?

[ThomThomson]

@flash1293, yes most apps clear the embeddable state transfer on navigating away, or navigating to their listing pages. This state can be cleared with stateTransfer.clearEditorState?.(APP_ID);

you can see an example x-pack/plugins/lens/public/app_plugin/save_modal_container.tsx line 320

EmbeddableStateTransfer is actually currently using session storage, which is why it needs to be explicitly cleared. The reason we did it that way was due to conflicts that caused the router state to be cleared intermittently.

I think those problems with router state have been fixed now. I wonder if it's time to move the state transfer service back to router state? @elastic/kibana-app-services

That said, looking at some of the problems that moving it to session storage solved I'm not so sure.