Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Disabled nested switch if horizontal legend alignment is selected #151196

Closed
Heenawter opened this issue Feb 14, 2023 · 5 comments
Closed
Labels
enhancement New value added to drive a business result Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@Heenawter
Copy link
Contributor

Kibana version: 8.7

Describe the bug:
When the Nested legend setting is true and the legend location is on the top or the bottom of the chart, the hierarchy of the labels is lost because the indentation is not consistent with when the legend is on the left or right of the chart.

Steps to reproduce:

  1. Create a nested donut chart
  2. Display the legend on the left or right of the chart
  3. Switch Nested to true - notice how the hierarchy of the labels is made clear.
  4. Change the location of the legend to the top or bottom of the chart - notice how the concept of hierarchy is lost 🔥

Expected behavior:
The inner labels should be indented to make the hierarchy of the labels clear, regardless of the legend position.

Video:

Screen.Recording.2023-02-14.at.11.10.17.AM.mov
@Heenawter Heenawter added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Feb 14, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@stratoula
Copy link
Contributor

I am not sure about it. @markov00 is this intended?

@markov00
Copy link
Member

Yes, it works as intented.
The problem is that a default horizontal legend configuration renders only 2 rows. Rendering the indentations in such a constraint is very confusing.

If you render more than two rows, like in the shared video it could work, but still, it will be far from ideal.
It needs definitely a redesign but not the way it works today (a clear hierarchical representation, collapsable hierarchical level etc).

I think what we could at Lens level is to disable the nested option for horizontal legends.

@stratoula stratoula changed the title [Lens] Nested hierarchy is lost for horizontal legend [Lens] Disabled nested switch if horizontal legend alignment is selected Feb 20, 2023
@stratoula stratoula added enhancement New value added to drive a business result and removed bug Fixes for quality problems that affect the customer experience blocked labels Feb 20, 2023
@stratoula
Copy link
Contributor

Agreed, I am changing this to enhancement

@stratoula
Copy link
Contributor

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@stratoula stratoula closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants