Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Accessibility) Discover - remove custom H1 focus on render now that global solution is in place #152131

Closed
1Copenut opened this issue Feb 24, 2023 · 2 comments · Fixed by #155613
Closed

(Accessibility) Discover - remove custom H1 focus on render now that global solution is in place #152131

1Copenut opened this issue Feb 24, 2023 · 2 comments · Fixed by #155613
Assignees
@jughosta
Labels
:DataDiscovery/fix-it-week Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Accessibility Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) WCAG A

Comments

@1Copenut
Copy link
Contributor

Description
We have been working on ways to improve screen reader announcement of route changes in Kibana for a number of months. Previously we experimented with setting focus on an H1 tag in Discover as a test case for future improvements. This has been superseded by a global change merged in PR #150461.

This ticket is being written to remove the custom H1 focus logic from #133846. The custom logic check will also need to be removed from the global solution, which I'll link below.

discover-h1-focus

Relevant Code Change

  • screen_reader_a11y.tsx#L50 has an array of app IDs to ignore the global screen reader handler. Removing 'Discover' from this array should enable the global behavior.

Actual Result

  • Focus is being set on the H1 on first render

Expected Result

  • Focus will be set at the top of the React app in a screen read only div. This will announce the breadcrumbs as a string to screen readers.

Kibana Version:
v8.8.0

OS:
MacOS Monterey

Browser:
Safari

Screen reader: [if relevant]
VoiceOver

Relevant WCAG Criteria:
Understanding SC 1.3.2: Meaningful Sequence (Level A)
@1Copenut 1Copenut added Feature:Discover Discover Application Project:Accessibility WCAG A Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) labels Feb 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@davismcphee davismcphee added loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Feb 24, 2023
@davismcphee davismcphee added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. :DataDiscovery/fix-it-week and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Apr 21, 2023
@jughosta jughosta self-assigned this Apr 24, 2023
@jughosta jughosta mentioned this issue Apr 24, 2023
Merged
jughosta added a commit that referenced this issue May 22, 2023
@jughosta
[Discover] Remove custom h1 focus logic. Unskip tests. (#155613)
633444e 
Closes #152131
Closes #152938

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2163
delanni pushed a commit to delanni/kibana that referenced this issue May 25, 2023
@jughosta @delanni
[Discover] Remove custom h1 focus logic. Unskip tests. (elastic#155613)
af14448 
Closes elastic#152131
Closes elastic#152938

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
:DataDiscovery/fix-it-week Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Accessibility Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) WCAG A
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] Remove custom h1 focus logic. Unskip tests. jughosta/kibana
4 participants
@1Copenut @jughosta @elasticmachine @davismcphee