Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Migrate number of hits from UnifiedHistogram to UnifiedDataTable #168825

Closed
Tracked by #168084
kertal opened this issue Oct 13, 2023 · 6 comments · Fixed by #171638
Closed
Tracked by #168084

[Discover] Migrate number of hits from UnifiedHistogram to UnifiedDataTable #168825

kertal opened this issue Oct 13, 2023 · 6 comments · Fixed by #171638
Assignees
@jughosta
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews)

Comments

@kertal
Copy link
Member

kertal commented Oct 13, 2023

In our ongoing Discover redesign, we aim to move the number of returned documents / rows to the toolbar region of the UnifiedDataTable

Image
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 13, 2023
@kertal kertal added Feature:Discover Discover Application Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) and removed needs-team Issues missing a team label labels Oct 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added the enhancement New value added to drive a business result label Oct 13, 2023
@kertal kertal added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Oct 13, 2023
@kertal kertal changed the title [Discover] Move total hits down to the UnifiedDataTable [Discover] Migrate number of hits from UnifiedHistogram to UnifiedDataTable Oct 13, 2023
@Ruhshan
Copy link
Contributor

Ruhshan commented Oct 16, 2023

Hi, may I pick this one? @kertal @jughosta

@Ruhshan
Copy link
Contributor

Ruhshan commented Oct 17, 2023

Hi,
So far what I could do is, like this:
image

I could programmatically show/hide the hits from unifiedHistoGram component,
But, unable to put the hits on unifiedDataTable, because the component where the toolbar exists is coming from EuiDataGrid, codes for this component doesn't exist in this repo, It looks like its coming from eui package.

So, either we have to update the EuiDataGrid in the eui package or if there are any api for the component already exists, to programmatically update toolbar contents, pointing that out to me will be much appreciated.

Tia.

@kertal @jughosta

@jughosta
Copy link
Contributor

Hi @Ruhshan,

Thanks for your interest! We have it on our roadmap to address soon. But before that we are making some changes which would enable this work: #166744 elastic/eui#7190

I think label loe:small is misleading. There is complexity of how total number of hits is displayed in the histogram due to different modes (data view vs ES|QL) and partial responses. We should refactor this to work outside of the histogram.

@jughosta jughosta added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Oct 18, 2023
@kertal
Copy link
Member Author

kertal commented Oct 18, 2023

+1 to everything @jughosta said, if you want to contribute to Kibana, which is highly appreciated, how about #167271 ? which should be a smaller issue?

@kertal kertal mentioned this issue Oct 18, 2023
Closed
@Ruhshan
Copy link
Contributor

Ruhshan commented Oct 18, 2023

Thanks for clarifying @jughosta, sure I will take a look on the mentioned issue @kertal.

@jughosta jughosta mentioned this issue Nov 21, 2023
Merged
4 tasks
@kertal kertal mentioned this issue Nov 28, 2023
Open
jughosta added a commit that referenced this issue Jan 12, 2024
@jughosta @kibanamachine
@stratoula @davismcphee
[Discover] Move total hits counter from histogram to grid area. New c…
aa33843 
…ontrols in histogram. (#171638)

- Closes #168825
- Closes #171610
- Closes #167427
- Partially addresses #165192

## Summary

This PR moves the total hits counter closer to the grid, updates
histogram controls and introduces new panel toggle buttons for toggling
fields sidebar and histogram.

<img width="500" alt="Screenshot 2023-12-05 at 15 37 20"
src="https://github.com/elastic/kibana/assets/1415710/5b9bd771-1052-4205-849f-18c21cc299b8">
<img width="500" alt="Screenshot 2023-12-05 at 15 37 29"
src="https://github.com/elastic/kibana/assets/1415710/e5941b27-c497-4d7e-b461-68b66931475a">
<img width="500" alt="Screenshot 2023-12-05 at 15 37 37"
src="https://github.com/elastic/kibana/assets/1415710/97abd32e-9ff2-4d9a-b7e7-b9d6d9cf64db">
<img width="500" alt="Screenshot 2023-12-05 at 15 37 50"
src="https://github.com/elastic/kibana/assets/1415710/10f2b4f4-ec37-41c3-b78b-78c64e14d655">
<img width="400" alt="Screenshot 2023-12-05 at 15 37 59"
src="https://github.com/elastic/kibana/assets/1415710/ef2e28b2-f6ba-4ccb-aea4-3946ba2d5839">
<img width="300" alt="Screenshot 2023-12-05 at 15 38 05"
src="https://github.com/elastic/kibana/assets/1415710/07901ede-0bcb-46a6-a398-4562189fd54f">
<img width="500" alt="Screenshot 2023-12-05 at 15 40 38"
src="https://github.com/elastic/kibana/assets/1415710/17830115-2111-4b8f-ae40-7b5875c06879">
<img width="500" alt="Screenshot 2023-12-05 at 15 40 56"
src="https://github.com/elastic/kibana/assets/1415710/975d475b-280b-495a-b7b7-31c7ade5f21e">
<img width="500" alt="Screenshot 2023-12-05 at 15 43 08"
src="https://github.com/elastic/kibana/assets/1415710/38b6053a-e260-48d8-9591-3f3409df2876">

## Testing

When testing, please check collapsing/expanding the fields sidebar and
histogram. Also for ES|QL mode with suggestions, legacy table, no
results and error prompt, Field Statistics tab, data views without a
time field, light/dark themes.

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
Co-authored-by: Davis McPhee <[email protected]>
semd pushed a commit to semd/kibana that referenced this issue Jan 12, 2024
@jughosta @kibanamachine
@stratoula @davismcphee @semd
[Discover] Move total hits counter from histogram to grid area. New c…
62edc8b 
…ontrols in histogram. (elastic#171638)

- Closes elastic#168825
- Closes elastic#171610
- Closes elastic#167427
- Partially addresses elastic#165192

## Summary

This PR moves the total hits counter closer to the grid, updates
histogram controls and introduces new panel toggle buttons for toggling
fields sidebar and histogram.

<img width="500" alt="Screenshot 2023-12-05 at 15 37 20"
src="https://github.com/elastic/kibana/assets/1415710/5b9bd771-1052-4205-849f-18c21cc299b8">
<img width="500" alt="Screenshot 2023-12-05 at 15 37 29"
src="https://github.com/elastic/kibana/assets/1415710/e5941b27-c497-4d7e-b461-68b66931475a">
<img width="500" alt="Screenshot 2023-12-05 at 15 37 37"
src="https://github.com/elastic/kibana/assets/1415710/97abd32e-9ff2-4d9a-b7e7-b9d6d9cf64db">
<img width="500" alt="Screenshot 2023-12-05 at 15 37 50"
src="https://github.com/elastic/kibana/assets/1415710/10f2b4f4-ec37-41c3-b78b-78c64e14d655">
<img width="400" alt="Screenshot 2023-12-05 at 15 37 59"
src="https://github.com/elastic/kibana/assets/1415710/ef2e28b2-f6ba-4ccb-aea4-3946ba2d5839">
<img width="300" alt="Screenshot 2023-12-05 at 15 38 05"
src="https://github.com/elastic/kibana/assets/1415710/07901ede-0bcb-46a6-a398-4562189fd54f">
<img width="500" alt="Screenshot 2023-12-05 at 15 40 38"
src="https://github.com/elastic/kibana/assets/1415710/17830115-2111-4b8f-ae40-7b5875c06879">
<img width="500" alt="Screenshot 2023-12-05 at 15 40 56"
src="https://github.com/elastic/kibana/assets/1415710/975d475b-280b-495a-b7b7-31c7ade5f21e">
<img width="500" alt="Screenshot 2023-12-05 at 15 43 08"
src="https://github.com/elastic/kibana/assets/1415710/38b6053a-e260-48d8-9591-3f3409df2876">

## Testing

When testing, please check collapsing/expanding the fields sidebar and
histogram. Also for ES|QL mode with suggestions, legacy table, no
results and error prompt, Field Statistics tab, data views without a
time field, light/dark themes.

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
Co-authored-by: Davis McPhee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
enhancement New value added to drive a business result Feature:Discover Discover Application impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews)
Projects
None yet
Milestone
No milestone
4 participants
@kertal @jughosta @Ruhshan @elasticmachine