Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Background poller runs regardless of ES health #18297

Closed
elasticmachine opened this issue Jun 29, 2017 · 3 comments
Closed

[Reporting] Background poller runs regardless of ES health #18297

elasticmachine opened this issue Jun 29, 2017 · 3 comments
Labels
bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Feature:Reporting:Framework Reporting issues pertaining to the overall framework needs-team Issues missing a team label

Comments

@elasticmachine
Copy link
Contributor

Original comment by @pickypg:

While debugging an unrelated issue last night, I noticed that regardless of the connection's health, Reporting will constantly fire its background poller.

It seems reasonable that it should be something more along the lines of:

let poller = null;

server.plugins.elasticsearch.status.on('green', () => {
  if (!poller) {
    poller = setInterval(trigger, config.get('xpack.reporting.poll_interval'));
  }
});

server.plugins.monitoring.status.on('red', () => {
  clearInterval(poller);
  poller = null;
});
@elasticmachine
Copy link
Contributor Author

Original comment by @kobelb:

@pickypg this situation should improve by the backoffs introduced by LINK REDACTED but I could see the desire to suspend polling based on the Elasticsearch's status as well.

@elasticmachine elasticmachine added :Sharing (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead bug Fixes for quality problems that affect the customer experience labels Apr 25, 2018
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed :Sharing labels Sep 13, 2018
@timroes timroes added Team:Stack Services and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 18, 2019
@bmcconaghy bmcconaghy added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) and removed Team:Stack Services labels Dec 12, 2019
@bmcconaghy bmcconaghy added Team:Reporting Services and removed Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Dec 20, 2019
@elasticmachine
Copy link
Contributor Author

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@tsullivan
Copy link
Member

The proposed solution wouldn't work in Kibana New Platform. I am not sure that the New Platform will "automatically" solve this though. This question is one to track on the Reporting New Platform Migration issue: #53898

@sophiec20 sophiec20 added the Feature:Reporting:Framework Reporting issues pertaining to the overall framework label Aug 21, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Feature:Reporting:Framework Reporting issues pertaining to the overall framework needs-team Issues missing a team label
Projects
None yet
Development

No branches or pull requests

5 participants