-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Rule with cases connector after downgrading to essentials cannot be edited #189978
Comments
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/response-ops-cases (Feature:Cases) |
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
Pinging @elastic/response-ops (Team:ResponseOps) |
@cnasikas @yctercero can you please take a look at this issue? Thanks! |
This is likely an issue we'll run into when we break exceptions out into it's own subprivelege as well. We don't have a good way of saying you can edit this portion of the rule schema and not another. @banderror @marshallmain correct me here if I'm wrong, but I think we need to think through how to design such changes. |
@yctercero I think the question is, from the product/UX standpoint, what needs to happen with such rules on downgrade to essentials:
I guess, in any case, we want the rules to continue to be editable. When we have this understanding, we could think about what needs to be done technically. @yctercero Not sure I understand what is being asked with regards to exceptions and RBAC. |
@approksiu @ARWNightingale could you please confirm what the intended behavior should be here? |
When a rule is created an API key is also created and connected to the rule. The API key represents the user that created the rule. This is needed to execute the rule and the actions under the user's permission. When someone edits a rule, the API key is updated to represent the user who updated the rule. So, if we let the user update the rule without having access to cases the case action will start to fail due to permission errors. As @yctercero said we do not have a way to have different permissions per portions of the rule's schema. The downgrade scenario is interesting though because it means that no user has access to cases. Does the rule fail either way by downgrading to essentials? Related: #191681. |
@cnasikas cold we do something where we disable the action? Users would be able to delete the action, but we could still maintain it there in case they upgrade. How difficult would the concept of enabled/disabled actions be to introduce? |
@MadameSheema does this occur with the other actions that are only present for higher tiers or is this specific behavior to cases? |
@yctercero I tested and for the other connectors we allow to save the rule but we do not execute the actions. We also show a warning in the rule's flyout. For the system actions, we perform extra authorization checks this is why the update of the rule fails. We could skip the authorization if the license is not sufficient, allow the rule to be saved as with the other actions, and disable the action as you suggested. I prioritized it but I am not sure if we can make it for 8.16. |
@yctercero specific for cases connector/action. |
@cnasikas Thanks so much! That sounds like a great way forward. |
Originally reported by @dhurley14
Describe the bug:
Preconditions:
Steps to reproduce:
Current behavior:
The text was updated successfully, but these errors were encountered: