Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL]Pinned Filter gets retained in ES|QL mode #193794

Closed
bhavyarm opened this issue Sep 23, 2024 · 6 comments · Fixed by #193817
Closed

[ES|QL]Pinned Filter gets retained in ES|QL mode #193794

bhavyarm opened this issue Sep 23, 2024 · 6 comments · Fixed by #193817
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Feature:ES|QL ES|QL related features in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) Team:ESQL ES|QL related features in Kibana

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Sep 23, 2024

Kibana version: 8.160 snapshot

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging and snapshots

Describe the bug: If you add a filter and then pin it in any of the apps, Kibana retains the pinned filter in ES|QL mode.

Steps to reproduce:

  1. Create a pinned filter in Discover ->classic mode
  2. Click on try ES|QL
  3. Kibana has retained the pinned filter

Expected behavior: I expect them to be cleared(?)

Screenshots (if relevant):

es.Ql_filter_still_present.mp4
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:Filters Team:ESQL ES|QL related features in Kibana labels Sep 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula
Copy link
Contributor

Nice catch Bhavya! This is not released, I created a PR to fix it here #193817

@stratoula stratoula added Feature:Discover Discover Application Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) and removed Feature:Filters labels Sep 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@stratoula stratoula added the Feature:ES|QL ES|QL related features in Kibana label Sep 24, 2024
@stratoula stratoula added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Sep 24, 2024
@bhavyarm
Copy link
Contributor Author

@stratoula the bug will go out in 8.15.2 which is out this Thursday. But I think that is ok. This is definitely not a blocker. Cheers!

@stratoula
Copy link
Contributor

Bhavya this bug hasn't been released. We did the redesign in 8.16 unless I am missing something

@bhavyarm
Copy link
Contributor Author

@stratoula you are correct. I had both 8.16.0 and 815.2 open for testing. Sorry for the confusion. Double checked on 8.15.2 BC2 now. Will update the description. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Feature:ES|QL ES|QL related features in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) Team:ESQL ES|QL related features in Kibana
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants