[Dashboards][Telemetry] Dashboard loaded event is emitted before the dashboard is rendered for some journeys #193907
Assignees
Labels
impact:high
Addressing this issue will have a high level of impact on the quality/strength of our product.
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
Comments
thomasneirynck
added
the
bug
thomasneirynck
removed
bug
thomasneirynck
added
the
impact:high
thomasneirynck
added
the
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
1 task
thomasneirynck
added a commit
that referenced
this issue
Oct 11, 2024
…ls have been added to a dashboard (#194349) ## Summary Closes #193907. The existing implementation suffers from a race condition where the performamce-tracker would start to evaluate the render-state of a dashboard before all panels have been added. When a panel-type (such as a markdown viz) would already have a completed render-state (ie last Phase-event === `rendered`), it would consider the entire dashboard as rendered. This is a spot fix which delays evaluating the dashboard-render state until all panels have been added to the dashboard (ie. `getPanelCount` matches the number of panels that are being observed by the performance tracker). I slightly edited some of the Observable-piping to a series that I believe is a little bit more readable. This has opened a larger discussion of whether Phase-events are the right way to check for completeness, and whether they should juse use the `RenderCompleteDispatcher` instead. However, given the size of the impact, a fuller investigation will come after this fix. ### Checklist ### Risk Matrix ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 11, 2024
…ls have been added to a dashboard (elastic#194349) ## Summary Closes elastic#193907. The existing implementation suffers from a race condition where the performamce-tracker would start to evaluate the render-state of a dashboard before all panels have been added. When a panel-type (such as a markdown viz) would already have a completed render-state (ie last Phase-event === `rendered`), it would consider the entire dashboard as rendered. This is a spot fix which delays evaluating the dashboard-render state until all panels have been added to the dashboard (ie. `getPanelCount` matches the number of panels that are being observed by the performance tracker). I slightly edited some of the Observable-piping to a series that I believe is a little bit more readable. This has opened a larger discussion of whether Phase-events are the right way to check for completeness, and whether they should juse use the `RenderCompleteDispatcher` instead. However, given the size of the impact, a fuller investigation will come after this fix. ### Checklist ### Risk Matrix ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit e822571)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Kibana version:
mainDescribe the bug:
The
kibana_loadedevent is fired multiple times for theweb_logs_dashboard_esqlandflight_dashboardjourneys. The first time it is emitted much too early. This is a bug.This was likely introduced on Sept 10 with #192221.
e.g. note how after 9/10, the event is starting to get collected twice consistently. (the jittery peaks and values are due to test runs)
Steps to reproduce:
web_logs_dashboard_esqlorflight_dashboardjourney dashboardkibana_loadedevent is fired twiceExpected behavior:
The event should only be emitted when the dashboard has completed rendering.
The text was updated successfully, but these errors were encountered: