Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Obs Applications > Traces][SCREEN READER]: H1 tag should not include secondary information: 0005 #194987

Closed
1Copenut opened this issue Jun 24, 2024 · 0 comments · Fixed by #193880
Closed

[Obs Applications > Traces][SCREEN READER]: H1 tag should not include secondary information: 0005 #194987

1Copenut opened this issue Jun 24, 2024 · 0 comments · Fixed by #193880
Assignees
@alexwizp
Labels
defect-level-2 Serious UX disruption with workaround obs-accessibilty A11Y issues in the Obs. solution. Project:Accessibility Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team WCAG A

Comments

@1Copenut
Copy link
Contributor

1Copenut commented Jun 24, 2024 •
edited
Loading

Point of contact

@petrklapka

Description

See https://github.com/elastic/observability-accessibility/issues/62 for full description of the issue and code reference for a suggested fix.

Environment

Screenshots or Trace Logs

Screenshot 2024-06-24 at 11 35 01 AM

WCAG or Vendor Guidance (optional)
@1Copenut 1Copenut added WCAG A defect-level-2 Serious UX disruption with workaround labels Jun 24, 2024
@1Copenut 1Copenut transferred this issue from another repository Jul 25, 2024
@smith smith added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Jul 25, 2024
@alexwizp alexwizp self-assigned this Sep 24, 2024
alexwizp referenced this issue in alexwizp/kibana Sep 24, 2024
@alexwizp
fix: [Obs Applications > Services | Traces | Dependencies][SCREEN REA…
dea622a 
…DER]: H1 tag should not include secondary information

Closes: https://github.com/elastic/observability-accessibility/issues/58; Closes: https://github.com/elastic/observability-accessibility/issues/57; Closes: https://github.com/elastic/observability-accessibility/issues/56
@alexwizp alexwizp mentioned this issue Sep 24, 2024
Merged
@alexwizp alexwizp transferred this issue from another repository Oct 4, 2024
@alexwizp alexwizp transferred this issue from elastic/transfer-issues Oct 4, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 8, 2024
@alexwizp
fix: [Obs Applications > Services | Traces | Dependencies][SCREEN REA…
d441b54 
…DER]: H1 tag should not include secondary information (elastic#193880)

Closes: elastic#194988
Closes: elastic#194987
Closes: elastic#194986

## Description
Observability has a few pages that wrap related information like alert
counts in the H1 tag. This presents a challenge to screen readers
because all of that information now becomes the heading level one. It
clogs up the Headings menu and makes it harder to reason about the page
and what's primary information vs. secondary.

## What was changed?:

1. extra content has been removed from `pageTitle` and moved to
`rightSideItems`.

## Screen:

<img width="1226" alt="image"
src="https://github.com/user-attachments/assets/221a1d80-7686-47e3-b0d1-b8c8eada9374">

> [!NOTE]
> On smaller screens (at certain resolutions) sometimes we have an issue
described in elastic/eui#8039 . But It's not a
blocker for that PR and will be fixed on EUI side

(cherry picked from commit a78a31d)
@smith smith added the obs-accessibilty A11Y issues in the Obs. solution. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
defect-level-2 Serious UX disruption with workaround obs-accessibilty A11Y issues in the Obs. solution. Project:Accessibility Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team WCAG A
Projects
None yet
Milestone
No milestone
3 participants
@smith @1Copenut @alexwizp