Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Timelion broken due to internal API requests being rejected #195297

Closed
Heenawter opened this issue Oct 7, 2024 · 3 comments · Fixed by #195790
Closed

[Canvas] Timelion broken due to internal API requests being rejected #195297

Heenawter opened this issue Oct 7, 2024 · 3 comments · Fixed by #195790
Assignees
@nickpeihl
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Heenawter
Copy link
Contributor

Describe the bug:
Timelion visualizations are broken in Canvas because the /internal/timelion/run request is being rejected with the following error:

uri [/internal/timelion/run] with method [post] exists but is not available with the current configuration

I believe this is because the default value of restrictInternalApis was changed from false to true in #193792.

Steps to reproduce:

  1. Download the sample data
  2. Open the Ecommerce sample workpad
  3. Notice how the Timelion visualizations show an error 🔥

Image

Expected behavior:
All visualizations should load
@Heenawter Heenawter added bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Oct 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Heenawter Heenawter mentioned this issue Oct 7, 2024
Merged
2 tasks
Heenawter added a commit that referenced this issue Oct 8, 2024
@Heenawter @cqliu1
[Canvas] Cleanup services (#194634)
91c045d 
Closes #194050

## Summary

This PR refactors the Canvas services to no longer use the
`PluginServiceProvider` from the `PresentationUtil` plugin. Note that
the Canvas storybooks are broken on main (and they have been for who
knows how long) and so, while I did make some changes to the storybooks
to make them **compile**, I didn't bother to get them fully functional.

Note that the Ecommerce workpad is broken - this is not due to this PR,
it is a [bug](#195297) that is
present on main.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)


<!--ONMERGE {"backportTargets":["8.x"]} ONMERGE-->

---------

Co-authored-by: Catherine Liu <[email protected]>
@Heenawter Heenawter mentioned this issue Oct 9, 2024
Merged
Heenawter added a commit to Heenawter/kibana that referenced this issue Oct 9, 2024
@Heenawter
[Canvas] Cleanup services (elastic#194634)
82fa144 
Closes elastic#194050

## Summary

This PR refactors the Canvas services to no longer use the
`PluginServiceProvider` from the `PresentationUtil` plugin. Note that
the Canvas storybooks are broken on main (and they have been for who
knows how long) and so, while I did make some changes to the storybooks
to make them **compile**, I didn't bother to get them fully functional.

Note that the Ecommerce workpad is broken - this is not due to this PR,
it is a [bug](elastic#195297) that is
present on main.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

<!--ONMERGE {"backportTargets":["8.x"]} ONMERGE-->

---------

Co-authored-by: Catherine Liu <[email protected]>
(cherry picked from commit 91c045d)
Heenawter added a commit that referenced this issue Oct 9, 2024
@Heenawter
[8.x] [Canvas] Cleanup services (#194634) (#195639)
a177282 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Canvas] Cleanup services
(#194634)](#194634)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Hannah
Mudge","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-08T20:34:01Z","message":"[Canvas]
Cleanup services (#194634)\n\nCloses
https://github.com/elastic/kibana/issues/194050\r\n\r\n##
Summary\r\n\r\nThis PR refactors the Canvas services to no longer use
the\r\n`PluginServiceProvider` from the `PresentationUtil` plugin. Note
that\r\nthe Canvas storybooks are broken on main (and they have been for
who\r\nknows how long) and so, while I did make some changes to the
storybooks\r\nto make them **compile**, I didn't bother to get them
fully functional.\r\n\r\nNote that the Ecommerce workpad is broken -
this is not due to this PR,\r\nit is a
[bug](#195297) that
is\r\npresent on main.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n\r\n<!--ONMERGE
{\"backportTargets\":[\"8.x\"]}
ONMERGE-->\r\n\r\n---------\r\n\r\nCo-authored-by: Catherine Liu
<[email protected]>","sha":"91c045d698b2e68afd13f5d4bef9229d8a231abe","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","loe:medium","technical
debt","release_note:skip","impact:high","v9.0.0","backport:prev-minor"],"number":194634,"url":"https://github.com/elastic/kibana/pull/194634","mergeCommit":{"message":"[Canvas]
Cleanup services (#194634)\n\nCloses
https://github.com/elastic/kibana/issues/194050\r\n\r\n##
Summary\r\n\r\nThis PR refactors the Canvas services to no longer use
the\r\n`PluginServiceProvider` from the `PresentationUtil` plugin. Note
that\r\nthe Canvas storybooks are broken on main (and they have been for
who\r\nknows how long) and so, while I did make some changes to the
storybooks\r\nto make them **compile**, I didn't bother to get them
fully functional.\r\n\r\nNote that the Ecommerce workpad is broken -
this is not due to this PR,\r\nit is a
[bug](#195297) that
is\r\npresent on main.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n\r\n<!--ONMERGE
{\"backportTargets\":[\"8.x\"]}
ONMERGE-->\r\n\r\n---------\r\n\r\nCo-authored-by: Catherine Liu
<[email protected]>","sha":"91c045d698b2e68afd13f5d4bef9229d8a231abe"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194634","number":194634,"mergeCommit":{"message":"[Canvas]
Cleanup services (#194634)\n\nCloses
https://github.com/elastic/kibana/issues/194050\r\n\r\n##
Summary\r\n\r\nThis PR refactors the Canvas services to no longer use
the\r\n`PluginServiceProvider` from the `PresentationUtil` plugin. Note
that\r\nthe Canvas storybooks are broken on main (and they have been for
who\r\nknows how long) and so, while I did make some changes to the
storybooks\r\nto make them **compile**, I didn't bother to get them
fully functional.\r\n\r\nNote that the Ecommerce workpad is broken -
this is not due to this PR,\r\nit is a
[bug](#195297) that
is\r\npresent on main.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n\r\n<!--ONMERGE
{\"backportTargets\":[\"8.x\"]}
ONMERGE-->\r\n\r\n---------\r\n\r\nCo-authored-by: Catherine Liu
<[email protected]>","sha":"91c045d698b2e68afd13f5d4bef9229d8a231abe"}}]}]
BACKPORT-->
@nickpeihl nickpeihl mentioned this issue Oct 10, 2024
Merged
@nickpeihl nickpeihl added loe:small Small Level of Effort and removed loe:needs-research This issue requires some research before it can be worked on or estimated labels Oct 10, 2024
@nickpeihl nickpeihl self-assigned this Oct 10, 2024
@nickpeihl nickpeihl reopened this Oct 21, 2024
@nickpeihl
Copy link
Member

Due to more restrictions on internal HTTP APIs, Timelion visualizations in Canvas are broken again. I attempted to fix this in #195790, but now it seems the only way to get Timelion expressions to render is to add server.restrictInternalApis: false to kibana.yml.

@nickpeihl
Copy link
Member

Due to more restrictions on internal HTTP APIs, Timelion visualizations in Canvas are broken again. I attempted to fix this in #195790, but now it seems the only way to get Timelion expressions to render is to add server.restrictInternalApis: false to kibana.yml.

Closing this again, because I re-tested Timelion in Canvas and it is working as expected. Apologies for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickpeihl nickpeihl

Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Canvas] Use core http method to access internal API nickpeihl/kibana
3 participants
@nickpeihl @Heenawter @elasticmachine