Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action factory registry #55345

Closed
3 of 5 tasks
streamich opened this issue Jan 20, 2020 · 1 comment
Closed
3 of 5 tasks

Action factory registry #55345

streamich opened this issue Jan 20, 2020 · 1 comment
Assignees
Labels
Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame

Comments

@streamich
Copy link
Contributor

streamich commented Jan 20, 2020

  • Add action factory registry to ui_actions e145241 Drilldown factory #59823
    • Action factories should implement Presentable interface
  • Add .revive() (or .createAction) method to UiActionsService, which constructs an instance of an action from its serialized form. "revive" was added to DynamicActionManager instead. Drilldown events 3 #59854

"Destinations registry" is a virtual registry, in reality we will re-use actions registry to store all drilldown destinations. UI actions that have type set to {type: 'destination'} are said to be "destinations" and subset of all actions in actions registry with {type: 'destination'} is "destinations registry". Those actions will also be of type IDynamicActionFactory.

Any plugin can register any number of possible destinations. This destination list is presented to the user when configuring a drilldown.

  • Extend ui_actions plugin to allow filtering actions by type.
  • Make sure type is used correctly in all existing action implementations. (for example, that nobody uses destination type or in some other incorrect way.)

Parent issue: #55349

@streamich streamich added Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame Team:AppArch labels Jan 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

This was referenced Jan 20, 2020
@streamich streamich added the 1sp label Jan 20, 2020
@streamich streamich changed the title Destinations registry (drilldowns) Action factory registry Feb 26, 2020
@streamich streamich removed the 1sp label Feb 26, 2020
@streamich streamich assigned streamich and Dosant and unassigned mattkime Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame
Projects
None yet
Development

No branches or pull requests

4 participants