Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL editor improvements #69413

Closed
4 of 5 tasks
Tracked by #55324
streamich opened this issue Jun 17, 2020 · 3 comments · Fixed by #88577
Closed
4 of 5 tasks
Tracked by #55324

URL editor improvements #69413

streamich opened this issue Jun 17, 2020 · 3 comments · Fixed by #88577
Assignees
Labels
Feature:Drilldowns Embeddable panel Drilldowns loe:large Large Level of Effort

Comments

@streamich
Copy link
Contributor

streamich commented Jun 17, 2020

Create a more powerful and user-friendly text input for editing URLs with interpolated Handlebars variables. This should probably be Monaco editor with custom written or modified mode.

Possible features:

  • Syntax highlighting for Handlebars variables.
  • Syntax highlighting for different URL parts.
  • Autocompletion for Handlebars variables.
  • Description text for each variable inside autocomplete popup.
  • Show autocomplete popup on Handlebars variable mouse click/hover.

👆 Those are just preliminary ideas. Maybe some of the above would be hard to impossible to achieve.

Q: Maybe this should be a EUI component? Similar to markdown editor: https://elastic.github.io/eui/#/editors-syntax/markdown-editor

Q: Maybe this should be related to custom api actions builder? @Dosant: to link an issue

Part of #55324

@streamich streamich mentioned this issue Jun 17, 2020
16 tasks
@streamich streamich added Feature:Drilldowns Embeddable panel Drilldowns Team:AppArch labels Jun 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@Dosant
Copy link
Contributor

Dosant commented Jun 17, 2020

POC with EUICodeEditor for suggestions and some highlighting:
https://codesandbox.io/s/heuristic-elbakyan-v7n1x?file=/index.js

@Dosant
Copy link
Contributor

Dosant commented Jul 21, 2020

POC used EUICodeEditor, but we should try newer MonacoEditor.

@Dosant Dosant added the loe:large Large Level of Effort label Jul 21, 2020
@Dosant Dosant changed the title URL template editor URL editor improvements Sep 24, 2020
@streamich streamich mentioned this issue Feb 1, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Drilldowns Embeddable panel Drilldowns loe:large Large Level of Effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants