Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drilldowns] URL drilldown better URL preview #78408

Closed
Dosant opened this issue Sep 24, 2020 · 2 comments
Closed

[Drilldowns] URL drilldown better URL preview #78408

Dosant opened this issue Sep 24, 2020 · 2 comments
Labels
Feature:Drilldowns Embeddable panel Drilldowns

Comments

@Dosant
Copy link
Contributor

Dosant commented Sep 24, 2020

Part of #55324

There is a confusing UX edge case with URL preview in initial URL drilldown implementation #69409

When drilldown is created, editor component doesn't know much about underlying data shape.
In preview it just relies on typescript shape of trigger's context.

Edge cases that we don't cover:

  1. Array of points: ({{event.points}}). The number of points in the array in preview could be different from runtime
  2. Different types. For example: {{event.from}} could be a date or a number. In preview we assume it is date. In runtime it could be a number
  3. Impossible to test against conditions.

In this issue I explained this edge cases in details: #76226

We should explore if we could solve this by:

  1. Providing samples of trigger context to drilldown editor
  2. Relying on more detailed triggers instead of generic value_click and range_select
  3. Now mock values are hardcoded, but we could allow users to manually edit those to test out different scenarios. This would be especially useful when we create a drilldown template (no access to real data on this point). @Dosant: to link an issue
@Dosant Dosant added Team:AppArch Feature:Drilldowns Embeddable panel Drilldowns labels Sep 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@Dosant Dosant mentioned this issue Sep 24, 2020
16 tasks
@streamich
Copy link
Contributor

Closing this as we removed preview feature, as {{event.*}} scoped variables are too dynamic to construct a correct preivew.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Drilldowns Embeddable panel Drilldowns
Projects
None yet
Development

No branches or pull requests

3 participants