Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] TMS allows invalid URL to be added as layer #92740

Closed
kindsun opened this issue Feb 25, 2021 · 2 comments
Closed

[Maps] TMS allows invalid URL to be added as layer #92740

kindsun opened this issue Feb 25, 2021 · 2 comments
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation impact:low Addressing this issue will have a low level of impact on the quality/strength of our product.

Comments

@kindsun
Copy link
Contributor

kindsun commented Feb 25, 2021

Currently there are no checks or validation that a TMS source is valid prior to adding. A user can input a completely erroneous URL and then advance to layer settings with no warning or indication the URL is invalid. This also means that if a URL were to become invalid (like if a server goes down) there would be no indication to the user. Related to #30588

We should be preventing a user from adding invalid layers and also showing an indicator in the TOC when a TMS layer isn't available.

image

To Test:

  1. Go to Add layer > Tile map service
  2. Add the following mistyped URL: http://c.tile.staen.com/watercolor/{z}/{x}/{y}.jpg (it's missing the m in stamen)
  3. Skip attribution and click Add layer
@kindsun kindsun added bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Feb 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Aug 4, 2021
@thomasneirynck
Copy link
Contributor

Closing. It's hard to validate if a server works for TMS. They may respond with errors for a given raster-tile, but that would still be valid behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation impact:low Addressing this issue will have a low level of impact on the quality/strength of our product.
Projects
None yet
Development

No branches or pull requests

4 participants