Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Windows NSIS Uninstallation Logic #8874

Open
ys928 opened this issue Feb 18, 2025 · 2 comments
Open

Issue with Windows NSIS Uninstallation Logic #8874

ys928 opened this issue Feb 18, 2025 · 2 comments
Assignees

Comments

@ys928
Copy link

ys928 commented Feb 18, 2025

I have encountered an issue with the NSIS uninstallation logic in the electron-builder. When using custom uninstallation commands, the current logic deletes all files before executing the custom uninstallation commands. This results in my uninstallation script being deleted before it can be executed.

Steps to Reproduce:

Create a custom uninstallation script.

Add the custom script to the NSIS uninstallation process.

Run the uninstallation process.

Expected Behavior: The custom uninstallation script should be executed before all files are deleted.

Actual Behavior: All files, including the custom uninstallation script, are deleted before the custom uninstallation commands are executed.

File Path: uninstaller.nsh

@ys928
Copy link
Author

ys928 commented Feb 18, 2025

After my testing, it was ok to move these three lines of script to line 144

Image

@mmaietta
Copy link
Collaborator

@beyondkmp can you take a look at this when you have a chance please?

@beyondkmp beyondkmp self-assigned this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants