Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'snap' command is deprecated, use 'pack' instead. #8880

Open
esimkowitz opened this issue Feb 20, 2025 · 4 comments
Open

The 'snap' command is deprecated, use 'pack' instead. #8880

esimkowitz opened this issue Feb 20, 2025 · 4 comments

Comments

@esimkowitz
Copy link

esimkowitz commented Feb 20, 2025

app-builder-lib needs to be updated to use the snapcraft pack command instead of snap when packaging for Snap targets

@mmaietta
Copy link
Collaborator

electron-builder uses app-builder-bin under the hood to assemble snap packages. Please open an issue here to track https://github.com/develar/app-builder

@mmaietta
Copy link
Collaborator

mmaietta commented Feb 21, 2025

@esimkowitz can you link me to the docs, or even cmd-line -help for the cmd, for snapcraft pack usage? I'm not finding any docs on it via the official docs https://snapcraft.io/docs/create-a-new-snap

Asking as it looks like the snap target implementation may need to be completely rewritten in JS. If so, would you be willing to help test the refactor once it is built out?

Related: Do you know when snap became the new cmd? Need to know so that I can do a semver check on which cmd to execute otherwise it's a breaking electron-builder semver bump.

@esimkowitz
Copy link
Author

esimkowitz commented Feb 21, 2025

I believe snapcraft pack replaced snap like 6 years ago, at least according to the deprecation notice
https://snapcraft.io/docs/deprecation-notice-6

It says it was introduced in Snapcraft 2.35

Also yeah totally down to help test the new imlementation

@mmaietta
Copy link
Collaborator

mmaietta commented Feb 24, 2025

Update: Working on a migration path atm from Go->TS: #8892 (Would love it if you could test the release afterwards. Tests pass on my Ubuntu arm64 VM and my mac for non-multipass tests. snapcraft and multipass are not available in docker containers or installable on mac GH runners it seems.)

Also turns out that snap unit tests were only snapshotting the cmd-line args being utilized for packaging the snap, so the CI new tests now actually test the full flow. 🎉

After a 1:1 migration, I'll explore the change to pack once the migration proves successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants