Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complains for deprecated move-file #1121

Open
crystalfp opened this issue Jan 18, 2024 · 3 comments
Open

Complains for deprecated move-file #1121

crystalfp opened this issue Jan 18, 2024 · 3 comments

Comments

@crystalfp
Copy link

Installing the package gives the following warning:

npm install --save-dev @electron/rebuild
npm WARN deprecated @npmcli/[email protected]: This functionality has been moved to @npmcli/fs

The installed versions are:

  • "@electron/rebuild": "^3.5.0"
  • npm: 10.3.0
  • node: 21.5.0
  • os: Windows 11 64 bits

Thanks for looking!
mario

@ThomasGreenspan
Copy link

Hi, is this being looked at by anyone?
There are a number of deprecated packages/versions that are indirect dependencies of this package:

  • inflight
  • npmlog
  • @npmcli/move-file
  • rimraf (old version)
  • are-we-there-yet
  • glob (old version)
  • gauge

I may have missed something but as far as I can tell, every single one of them would be taken care of by updating the node-gyp dep to v10+.
There is another issue that mentions the same thing here: #1116

It seems to have some activity but not sure how actively this is being worked on. Not sure how much trouble updating the dependency would be but there's a chance it's very easy. Would be nice for someone to look at it or explain why it's not possible right away.

Thanks!
Thomas

@MarshallOfSound
Copy link
Member

Bumping node-gyp to v10 is non trivial as it drops support for certain major versions of node.js that the rest of electrons official ecosystem packages support. Updating to that would have a ripple effect across the ecosystem that we aren't looking to effect right now.

There is work being done in the background to make updating node-gyp to 10 not a breaking change but it's not super urgent. E.g. this specific issue, a couple of deprecation warnings are by no means the end of the world 😄

@ThomasGreenspan
Copy link

Got it! Totally agree on lack of urgency, a few deprecation warnings aren't a big deal. Was just a bit of cleanup if it was easy.
Thanks for the explanation, much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants