Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading error message for file count mismatch #103

Open
erickzhao opened this issue Jun 13, 2024 · 0 comments
Open

Misleading error message for file count mismatch #103

erickzhao opened this issue Jun 13, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@erickzhao
Copy link
Member

The initial implementation for this library (163f495) threw an error if the count of Mach-O files was different between .app bundles.

'While trying to merge mach-o files across your apps we found a mismatch, the number of mach-o files is not the same between the arm64 and x64 builds',

In (46ff9c4), the scope of this check was widened to account for any file that wasn't an app.asar archive or a .bin V8 snapshot.

const dupedFiles = (files: AppFile[]) => files.filter(f => f.type !== AppFileType.SNAPSHOT && f.type !== AppFileType.APP_CODE);

However, the initial error message has not changed, which can be misleading for users encountering it.

I'm not sure if we only care about Mach-O files here and should also filter out AppFileType.PLAIN files in this check, or if the error message should be clarified instead.

@erickzhao erickzhao added the bug Something isn't working label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant