Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eastl::string_hash_map doesn't have move constructor and operator #552

Open
snaulX opened this issue Jan 19, 2025 · 1 comment
Open

eastl::string_hash_map doesn't have move constructor and operator #552

snaulX opened this issue Jan 19, 2025 · 1 comment

Comments

@snaulX
Copy link

snaulX commented Jan 19, 2025

I needed to compile non-copyable class with eastl::string_hash_map member but seems like it doesn't implement move semantics. Is it bug or design decision?

@jhopkins-ea
Copy link
Contributor

This is an oversight in the implementation and missing functionality.

Note that in the upcoming version of eastl the string_hash_map type has limited utility because we have implemented heterogeneous lookup for associative containers, eg. hash_map, which provides the same optimization. From the release notes:

Add support for C++14's heterogeneous comparison lookup (N3657), C++23's heterogeneous erasure (P2077R3) and C++26's heterogeneous insertion (P2363R5) functions for set, multiset, hash_set, hash_multiset, fixed_set, fixed_multiset, fixed_hash_set, fixed_hash_multiset, vector_set, vector_multiset, vector_map & vector_multimap.

See overloads 3 & 4 here for an explanation of heterogeneous comparison lookup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants