Invisible crypto: Handle Identity Verification violation after we reset our own identity

[BillCarsonFr]

This is the symetrical issue of #2492, when there is a verification violation not because the other party changed their identity but rather the current user that reset their own identity.

Scenario:

1. Alice verifies Bob and Carol.
2. Alice now resets her identity

Now Bob and Carol are in verification violation, because they used to be verified but are not any more.

Actual Problem

If we just do #2492 the UI will say Bob's verified identity has changed with the option to Withdraw verification or to re-verify.

=> This message is factually false. Bob identity has not changed, it's Alice's identity that changed.

Expected

There are several options.

1. We could automatically withdraw all verification requirements after the reset.
   • Problem: given that withdraw is local, Alice's other devices will still show the violation.
2. Detect when the violation is due to own identity change, and display a specific message
   • This case could be detected by noticing that there is a verification violation but not a pin violation.
3. Does (future) Global Pinning (as opposed to local pinning) (ER-156) help here?
4. Use a more generic message: XX was verified but is not anymore, then go through the details in the learn more?

[richvdh]

Also related to post-reset behaviour: #2610

[mxandreas]

with the option to Withdraw verification or to re-verify.

@BillCarsonFr Just in case to point out that the problem is not only with the wording in the banner that shows up on top of the composer, but everywhere where we using the wording 'X's verified identity has changed'. There are other cases on UI where we show it.

[BillCarsonFr]

with the option to Withdraw verification or to re-verify.

@BillCarsonFr Just in case to point out that the problem is not only with the wording in the banner that shows up on top of the composer, but everywhere where we using the wording 'X's verified identity has changed'. There are other cases on UI where we show it.

Right, it applies to the send error copy and stopgap UI.
#2500

and