Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on the Room List section label doesn't allow to jump to the top of it anymore #21420

Open
AmandineLP opened this issue Mar 15, 2022 · 1 comment
Labels
A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression

Comments

@AmandineLP
Copy link
Contributor

this is a problem as sometimes I end up having the room list scrolled quite far down (I think because I use search to find a room, and when I get into the room the room list scrolls down to where the room is), and I can't scroll back up quickly. Previously if the room list was scrolled down clicking on 'Rooms' would bring me back to the top of the list of rooms. Then I had to click on People then Favourites to eventually get back to my default preferred state (Favourites + People + Rooms displayed), which was painful enough. Now I have no choice but use the scroll bar which is even worse. One way to work around this could be to not make the room list scroll down to where the room is when I get into a room from search (it doesn't bring anything to do this).

@dbkr dbkr added T-Defect X-Regression S-Minor Impairs non-critical functionality or suitable workarounds exist A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely labels Mar 15, 2022
@novocaine novocaine changed the title clicking on the section label doesn't allow to jump to the top of it anymore Clicking on the Room List section label doesn't allow to jump to the top of it anymore Mar 17, 2022
@turt2live turt2live self-assigned this Mar 17, 2022
@turt2live
Copy link
Member

During a call earlier I thought this was about jumping down the room list, but indeed it's a bug that jumping up the room list is now different. It appears as though matrix-org/matrix-react-sdk#7991 may have broken this, somehow, in that reverting the PR restores almost-working functionality.

Before 7991:

  1. Have lots of rooms under "Rooms" in your room list & show them all
  2. Scroll down a bunch so that the "Rooms" header is sticky to the top of the room list
  3. Click the "Rooms" header to try and scroll back up
  4. Note the (side-quest) bug which meant the room list wouldn't jump all the way up, instead stopping somewhere in the 66-75% towards the top mark, requiring further (multiple) clicks. This behaviour was not introduced by Fix room list being laggy while scrolling 🐌 matrix-org/matrix-react-sdk#7939 or Fix accessibility around the room list treeview and new search beta matrix-org/matrix-react-sdk#7856 which would have been prime candidates for this. The cause is unknown.

After 7991:

  1. Have lots of rooms under "Rooms" in your room list & show them all
  2. Scroll down a bunch so that the "Rooms" header is sticky to the top of the room list
  3. Click the "Rooms" header to try and scroll back up
  4. Rooms section is collapsed instead of jumping up to the top

From the call earlier, there is a separate bug where the "Low Priority" (or any header sicky to the bottom) has slightly weird behaviour post-7991:

  • If already collapsed, it will scroll down and expand (most of the time - I couldn't figure out repro steps, but sometimes it'll expand without scrolling)
  • If already expanded, it will collapse instead of scrolling down

Before 7991 the expected behaviour worked fine:

  • If already collapsed, it will scroll without expanding.
  • If already expanded, it will scroll without collapsing.

It was also mentioned that matrix-org/matrix-react-sdk#6054 might help this situation in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression
Projects
None yet
Development

No branches or pull requests

3 participants