Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design of secret key dialogs inconsistent #21572

Closed
luixxiul opened this issue Mar 27, 2022 · 8 comments
Closed

Design of secret key dialogs inconsistent #21572

luixxiul opened this issue Mar 27, 2022 · 8 comments
Labels
A-Appearance A-E2EE-Cross-Signing O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Needs-Design

Comments

@luixxiul
Copy link

luixxiul commented Mar 27, 2022 •
edited
Loading

Steps to reproduce

  1. Open a private tab on a browser
  2. Log in

Outcome

What did you expect?

The style of the dialogs should be consistent.

after2

after1

after

What happened instead?

Values of border-radius, color, padding, etc. are decided without a specific policy.

  • Reset all font color is different.
  • One of the footer lacks the warning sign.
  • The value of border-radius of the dialogs are slightly different
  • The padding of the dialogs are slightly different
  • The color of the text is slightly different

Operating system

No response

Application version

develop branch

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No
@luixxiul luixxiul changed the title Reset all on secret key dialogs inconsistent "Reset all" on secret key dialogs inconsistent Mar 27, 2022
@luixxiul luixxiul mentioned this issue Mar 27, 2022
Closed
@yaya-usman
Copy link
Contributor

@luixxiul can you assign me this issue?

@yaya-usman
Copy link
Contributor

@luixxiul can you assign me this issue?

Figured out there is a pull request already

@luixxiul
Copy link
Author

FYI I cannot assign anyone as I am not a team member.

@germain-gg germain-gg added S-Tolerable Low/no impact on users A-E2EE-Cross-Signing A-Appearance O-Occasional Affects or can be seen by some users regularly or most users rarely good first issue Good for newcomers labels Mar 28, 2022
@luixxiul luixxiul changed the title "Reset all" on secret key dialogs inconsistent Design of secret key dialogs inconsistent Mar 28, 2022
@goelesha
Copy link

@luixxiul I would like to work on the issue if it's still open.

@SimonBrandner
Copy link
Contributor

@luixxiul I would like to work on the issue if it's still open.

matrix-org/matrix-react-sdk#8167 already fixes the issue

@DevanshRaizada
Copy link

I would like to work on the issue if its still open?

@SimonBrandner
Copy link
Contributor

I would like to work on the issue if its still open?

matrix-org/matrix-react-sdk#8167 already fixes the issue

@kittykat kittykat added Help Wanted Extra attention is needed X-Needs-Design and removed Help Wanted Extra attention is needed good first issue Good for newcomers labels May 4, 2022
@luixxiul luixxiul removed their assignment Jun 4, 2023
@luixxiul
Copy link
Author

luixxiul commented Jun 4, 2023

I will not work on this issue.

@luixxiul luixxiul closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Appearance A-E2EE-Cross-Signing O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Needs-Design
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix style inconsistencies of "Verify this device" dialog
7 participants
@kittykat @germain-gg @luixxiul @SimonBrandner @yaya-usman @goelesha @DevanshRaizada