Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The class name of notification panel contains mx_ThreadPanel #25299

Closed
luixxiul opened this issue May 7, 2023 · 1 comment
Closed

The class name of notification panel contains mx_ThreadPanel #25299

luixxiul opened this issue May 7, 2023 · 1 comment
Labels
T-Task Tasks for the team like planning

Comments

@luixxiul
Copy link

luixxiul commented May 7, 2023

Steps to reproduce

  1. Create a new account and log in if you have a stuck notification
  2. Open a notification panel
  3. Check browser's devtool

Outcome

What did you expect?

The class name should be something general for panels.

What happened instead?

It includes mx_ThreadPanel though it has nothing to do with a thread. This is confusing and makes the panel more vulnerable to visual regressions.

1

Operating system

Debian

Browser information

Firefox

URL for webapp

app.element.io

Application version

No response

Homeserver

No response

Will you send logs?

No
@luixxiul
Copy link
Author

luixxiul commented May 7, 2023

It is noted with a comment on NotificationPanel.tsx though.

@dbkr dbkr added T-Task Tasks for the team like planning and removed T-Defect labels May 9, 2023
@luixxiul luixxiul changed the title The class name of empty notification panel contains mx_ThreadPanel The class name of notification panel contains mx_ThreadPanel Jun 5, 2023
@luixxiul luixxiul closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbkr @luixxiul