Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding a new space just redisplays the add dialog #25916

Closed
simonmichael opened this issue Aug 3, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11367
Closed

adding a new space just redisplays the add dialog #25916

simonmichael opened this issue Aug 3, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11367
Assignees
@t3chguy
Labels
A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression

Comments

@simonmichael
Copy link

Steps to reproduce

  1. Viewing a space's room list, eg
  2. Click the Add button
  3. Click Add space
  4. Fill out Name and Address fields (and optionally image and Description, same result)
  5. Click Add button

Outcome

What did you expect?

For this child space to be created and appear in the parent's room list

What happened instead?

The add dialog redisplays, showing no error.

Operating system

macos ventura

Application version

Element version: 1.11.37 Olm version: 3.2.14

How did you install the app?

No response

Homeserver

matrix.org

Will you send logs?

Yes
@t3chguy
Copy link
Member

t3chguy commented Aug 4, 2023

This is specific to public subspace creation, private works fine.

@t3chguy t3chguy self-assigned this Aug 4, 2023
@t3chguy
Copy link
Member

t3chguy commented Aug 4, 2023

Regressed by matrix-org/matrix-react-sdk#10652

@t3chguy t3chguy mentioned this issue Aug 4, 2023
Merged
@germain-gg germain-gg added A-Spaces Spaces, groups, communities S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Aug 7, 2023
@simonmichael simonmichael mentioned this issue Aug 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix create subspace dialog not working for public space creation matrix-org/matrix-react-sdk
3 participants
@simonmichael @germain-gg @t3chguy