Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User avatar in image lightbox overlay has spurious outline #26196

Closed
anoadragon453 opened this issue Sep 19, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11641
Closed

User avatar in image lightbox overlay has spurious outline #26196

anoadragon453 opened this issue Sep 19, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11641
Assignees
@germain-gg
Labels
A-Avatar A-Light-Box UI when viewing an image A-Media O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression Z-Compound

Comments

@anoadragon453
Copy link
Member

Steps to reproduce

  1. Open a room that has an image/gif sent in it
  2. Click on the media in order to view it
  3. See that the avatar of the user that sent the media is displayed in the top-left corner
  4. See that the avatar has a weird, green bounding box around it

image
(see top left)

Outcome

What did you expect?

For there to be no bounding box.

What happened instead?

image

The same occurs in both Element Web and Desktop. My guess is that some CSS was changed elsewhere, and it inadvertently added this here.

Operating system

NixOS Linux

Browser information

Firefox 117.0.1

URL for webapp

No response

Application version

Built from source today

Homeserver

No response

Will you send logs?

No
@t3chguy
Copy link
Member

t3chguy commented Sep 19, 2023

Comes from https://github.com/matrix-org/matrix-react-sdk/blob/d551469543c97202d5115c86c8a81ca96d1a62d0/res/css/_common.pcss#L613 which previously didn't affect this as we used mx_AccessibleButton instead of button

Regressed by matrix-org/matrix-react-sdk#11448

@t3chguy t3chguy added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Sep 19, 2023
@germain-gg germain-gg self-assigned this Sep 21, 2023
@germain-gg germain-gg mentioned this issue Sep 21, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A-Avatar A-Light-Box UI when viewing an image A-Media O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression Z-Compound
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix avatar styling in lightbox matrix-org/matrix-react-sdk
3 participants
@germain-gg @anoadragon453 @t3chguy