Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incoming user verification request toast says "Verify Session" #27393

Closed
richvdh opened this issue Apr 25, 2024 · 4 comments · Fixed by matrix-org/matrix-react-sdk#12605
Closed

Incoming user verification request toast says "Verify Session" #27393

richvdh opened this issue Apr 25, 2024 · 4 comments · Fixed by matrix-org/matrix-react-sdk#12605
Assignees
@t3chguy
Labels
A-E2EE-SAS-Verification A-Element-R Issues affecting the port of Element's crypto layer to Rust A-Tooltips Anything related to tooltips O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect

Comments

@richvdh
Copy link
Member

richvdh commented Apr 25, 2024

  • Alice sends Bob a verification request
  • Bob sees a toast with "Verify Session".

It should be "Verify User".
@richvdh richvdh added A-Element-R Issues affecting the port of Element's crypto layer to Rust T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist A-E2EE-SAS-Verification O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Apr 25, 2024
@dosubot dosubot bot added A-Tooltips Anything related to tooltips S-Tolerable Low/no impact on users labels Apr 25, 2024
@dhananjay0610
Copy link

Hey, I am raising pr for this, small fix

@richvdh
Copy link
Member Author

richvdh commented May 3, 2024

@dhananjay0610:

Hey, I am raising pr for this, small fix

did you get anywhere on this? As you say it's a small fix so if you're not able to work on it please say so, so someone else can pick it up.

@gongarher
Copy link

This would be the cause of #27056

@richvdh
Copy link
Member Author

richvdh commented May 9, 2024

This would be the cause of #27056

No, I don't think so. This is literally just a wording change in the UI.

@t3chguy t3chguy self-assigned this Jun 12, 2024
@t3chguy t3chguy mentioned this issue Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-E2EE-SAS-Verification A-Element-R Issues affecting the port of Element's crypto layer to Rust A-Tooltips Anything related to tooltips O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tweak copy for user verification toast matrix-org/matrix-react-sdk
4 participants
@richvdh @t3chguy @dhananjay0610 @gongarher