Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element offers to verify with Security Key when security key has been deleted #29133

Open
richvdh opened this issue Jan 29, 2025 · 0 comments
Open

Element offers to verify with Security Key when security key has been deleted #29133

richvdh opened this issue Jan 29, 2025 · 0 comments
Labels
A-E2EE-Cross-Signing O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@richvdh
Copy link
Member

richvdh commented Jan 29, 2025 •
edited
Loading

  1. Settings -> Encryption -> Advanced -> Reset cryptographic identity. (Alternatively: set m.secret_storage.default_key account data to {} via devtools)
  2. Confirm, enter password, etc
  3. log out
  4. Log in.
  5. Observe:
    Image

The security key has been deleted; it is impossible to verify with it and we should not offer to verify with it.

Similarly

  1. Do the above, skip the "verify this device" modal
  2. Settings -> Encryption -> Verify this device
  3. Image

This is a bug in SetupEncryptionStore, which checks if m.cross_signing.master is stored in secret storage, but does not check if it is encrypted with the current secret storage key.
@richvdh richvdh added T-Defect A-E2EE-Cross-Signing S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jan 29, 2025
@dosubot dosubot bot added A-E2EE O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jan 29, 2025
@florianduros florianduros added S-Minor Impairs non-critical functionality or suitable workarounds exist and removed S-Minor Impairs non-critical functionality or suitable workarounds exist A-E2EE O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE-Cross-Signing O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richvdh @florianduros