Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert current display name by click #4519

Closed
HarHarLinks opened this issue Jul 6, 2017 · 5 comments
Closed

insert current display name by click #4519

HarHarLinks opened this issue Jul 6, 2017 · 5 comments
Labels
P3 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@HarHarLinks
Copy link
Contributor

When clicking a user's display name ("DN") in chat history, the DN is inserted in the composer to mention them. If the DN changed after the post you want to mention them from, the old DN is inserted regardless. This breaks the mention function, unless a client keeps a list of all former DNs - which riot does not.

Expected behavior

Instead, I'd expect riot to either

  • insert the localpart instead, which can lead to unclarity, because we usually only see the current DN
  • get and insert the user's latest DN

Version information

  • Platform: web (in-browser) v0.11.4
  • Browser: Vivaldi 1.11.890.4
  • OS: Windows 7
  • URL: https://riot.im/app
@lampholder lampholder added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist P3 ui/ux labels Jul 6, 2017
@lampholder
Copy link
Member

This is a tricky one - all potential behaviours could be a little bit jarring, but I think you're right - the intended behaviour is to mention somebody, so perhaps fetching and inserting the user's current DN might be the least obstructive.

@lukebarnard1
Copy link
Contributor

The real solution to this is #2980

@lampholder
Copy link
Member

So clicking the user's name would insert a pill into the composer with their current avatar and display name?

@lukebarnard1
Copy link
Contributor

Yep, and there's a plan to insert the user's most recent display name when the pill gets rendered in the timeline

@HarHarLinks
Copy link
Contributor Author

This seems solved in the current version via #2980.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

3 participants