Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be able to dismiss read marker indicator #8666

Closed
turt2live opened this issue Feb 14, 2019 · 24 comments · Fixed by matrix-org/matrix-react-sdk#4159
Closed

Should be able to dismiss read marker indicator #8666

turt2live opened this issue Feb 14, 2019 · 24 comments · Fixed by matrix-org/matrix-react-sdk#4159
Labels
A-Read-Marker Green line showing how far _you_ have read P1 T-Enhancement Z-Community-PR Issue is solved by a community member's PR Z-Mozilla

Comments

@turt2live
Copy link
Member

I can't find the issue for this

@aaronraimist
Copy link
Collaborator

#8512 was the issue but I'll close that and thumbs up this cc @jryans

@ejpcmac
Copy link

ejpcmac commented Feb 15, 2019

Maybe the UX could be unified with #8541 for this issue. We should be able to dismiss messages per room, or community. Looking for the new behaviour to achieve this (in fact missing), I have tried:

  1. to right click on the unread inticator in the message views
  2. to click / right click on the room options in the side bar to see if the option was instead there

Maybe this can help.

@Throne3d
Copy link

Throne3d commented Feb 17, 2019

From #riot-web:matrix.org:

Throne3d, 02:35
Discord uses alt+clicks to let you manually mark some point read/unread, so you can move your unread marker to save your place if you're reading history
(it's not very well advertised as a feature)
I find that very useful – maybe it'd be a good thing to add wrt this?

(If you alt+click the last message in a channel, it marks the whole channel as read – in fact, it marks everything up to, and including, the message you click, as read, and everything after it as unread.)

Edit: I see now that this is probably worthwhile putting in element-hq/element-meta#347 instead, but I'll leave it here anyway :P

@tulir
Copy link
Contributor

tulir commented Feb 18, 2019

Could just jumping to read marker and back down dismiss it?

Message from @fladd:matrix.org:

if i jump down again that clearly is a sign that I read where the marker is, and don't care to read the rest. this should clear the marker and move it to the current position all the way down in my opinion

@ejpcmac
Copy link

ejpcmac commented Feb 19, 2019

Could just jumping to read marker and back down dismiss it?

@tulir This is not a good thing IMO. You can be interested in what’s currently going on in the channel while reading the logs. When doing this, you may want to go back and forth from your “last read” message to the current conversation.

@fladd
Copy link

fladd commented Feb 19, 2019

Maybe at least make it an option or so?
I am literally never interested in anything else than the last position. Once I have been there any marker should be entirely deleted. Right now, if I understand it correctly, the marker is just moved down half a screen or so.
For me the current behaviour just leads to a situation where I (a) constantly have a read marker somewhere in the room at a position I don't care about (might be weeks ago), and (b) cannot jump to the actual point where I last left the room. Hence, I currently just scroll up an manually search for where I last left the room, since this still gets me quicker there than starting from this random position in my room history where Riot has left the read marker at some point in the (distant) past.

@Mikaela
Copy link
Contributor

Mikaela commented Feb 20, 2019

I am missing the ability to mark room as read by pressing ESC which is supported by Discord and at least Telegram jumps to main screen with that.

@fladd
Copy link

fladd commented Feb 23, 2019

I see that in the newest version on /develop, the read marker is automatically cleared if you don't jump to it within 30 seconds after switching to the room. Nice! This should work for most people (although people need to know this, so they don't go away to get a coffee to prepare for reading through all this history, only to figure out after they got their coffee that the marker is gone :-) ).

@aperezdc
Copy link

Well, I am not a fan of the read marker being dismissed automatically after 30 seconds, but I guess it's better than nothing 🙃

@yangm97
Copy link

yangm97 commented Feb 23, 2019

Me neither. The fact riot allowed me to manage this manually kind of made it special.

@fladd
Copy link

fladd commented Feb 23, 2019

The problem with managing it manually is, that if you don't do that every single time you switch to a room, the read marker becomes entirely useless (as described above) :-)

@yangm97
Copy link

yangm97 commented Feb 24, 2019

And the problem with dismissing automatically is that you could lose the last location accidentally, making the feature useless :-)

Maybe a toggle would do well

@fladd
Copy link

fladd commented Feb 24, 2019 via email

@yangm97
Copy link

yangm97 commented Feb 24, 2019

That's how telegram does it too. Which means that I (and other people) end up replying some of the old messages with something like "#readfromhere" just so we can read/reply to other stuff without losing that point in time accidentally, for instance, when you open it on mobile but don't actually have time to read the entire thing or the fact that it's currently impossible to reply to messages once you jump to the last unread bit on riot mobile.

Personally I don't like it either, but it's a little more standard behavior at least.

@cuibonobo
Copy link

I think it is fine that the marker disappears after 30 seconds, but I would like a way to dismiss it manually. I will often jump quickly between rooms to see the latest things that have been happening and 30 seconds seems too long to wait for the marker to go away.

@yangm97
Copy link

yangm97 commented Apr 14, 2019

I would also love to be able to disable the behaviour of the marker vanishing on its own.

@altsalt
Copy link

altsalt commented May 15, 2019

Alternatively, it would be nice to have actually follow along as the text scrolls. Right now the assumed read speed is painfully slow. Often I just want to page down glancing for keywords.

@turt2live turt2live added X-Needs-Design P1 A-Read-Marker Green line showing how far _you_ have read ui/ux labels Jun 30, 2019
@MurzNN
Copy link
Contributor

MurzNN commented Jul 12, 2019

@needs-design - maybe like this?
image

@MurzNN
Copy link
Contributor

MurzNN commented Aug 5, 2019

Other way from RocketChat is pinned line on top of message list:
image

@MurzNN
Copy link
Contributor

MurzNN commented Oct 9, 2019

This feature is already re-implemented successfully in RiotX-Android via element-hq/element-android#328, so why Riot-Web still can't give back it with p1 priority? It is not hard, at first - with ugly design, but functional, second step - good design...

@kortschak
Copy link

Any chance of any movement on this? Throwing away tens of minutes each time I use riot to keep up with rooms' streams is a killer for usability here.

@mstriemer
Copy link

I put a simple patch up at matrix-org/matrix-react-sdk#4159, if that's something that's wanted I can spend a little more time on it to get it ready.

@turt2live turt2live added the Z-Community-PR Issue is solved by a community member's PR label Mar 2, 2020
@escapewindow
Copy link

If we could map the esc key as well, that would be perfect.

@mstriemer
Copy link

Looks like mark as read on escape is #12537. I agree that would be a nice feature, but I don't think these would depend on each other.

@jryans jryans removed the X-Blocked label Mar 10, 2020
su-ex added a commit to SchildiChat/element-web that referenced this issue Jun 7, 2022
* Make Lao translation available ([\element-hq#22358](element-hq#22358)). Fixes element-hq#22327.
* Option to disable hardware acceleration on Element Desktop ([\element-hq#22295](element-hq#22295)). Contributed by @novocaine.
* Configure custom home.html via `.well-known/matrix/client["io.element.embedded_pages"]["home_url"]` for all your element-web/desktop users ([\element-hq#7790](matrix-org/matrix-react-sdk#7790)). Contributed by @johannes-krude.
* Live location sharing - open location in OpenStreetMap ([\element-hq#8695](matrix-org/matrix-react-sdk#8695)). Contributed by @kerryarchibald.
* Show a dialog when Jitsi encounters an error ([\element-hq#8701](matrix-org/matrix-react-sdk#8701)). Fixes element-hq#22284.
* Add support for setting the `avatar_url` of widgets by integration managers. ([\element-hq#8550](matrix-org/matrix-react-sdk#8550)). Contributed by @Fox32.
* Add an option to ignore (block) a user when reporting their events ([\element-hq#8471](matrix-org/matrix-react-sdk#8471)).
* Add the option to disable hardware acceleration ([\element-hq#8655](matrix-org/matrix-react-sdk#8655)). Contributed by @novocaine.
* Slightly better presentation of read receipts to screen reader users ([\element-hq#8662](matrix-org/matrix-react-sdk#8662)). Fixes element-hq#22293. Contributed by @pvagner.
* Add jump to related event context menu item ([\element-hq#6775](matrix-org/matrix-react-sdk#6775)). Fixes element-hq#19883.
* Add public room directory hook ([\element-hq#8626](matrix-org/matrix-react-sdk#8626)).
* Stop Jitsi if we time out while connecting to a video room ([\element-hq#22301](element-hq#22301)). Fixes element-hq#22283.
* Remove inline margin from UTD error message inside a reply tile on ThreadView ([\element-hq#8708](matrix-org/matrix-react-sdk#8708)). Fixes element-hq#22376. Contributed by @luixxiul.
* Move unread notification dots of the threads list to the expected position ([\element-hq#8700](matrix-org/matrix-react-sdk#8700)). Fixes element-hq#22350. Contributed by @luixxiul.
* Prevent overflow of grid items on a bubble with UTD generally ([\element-hq#8697](matrix-org/matrix-react-sdk#8697)). Contributed by @luixxiul.
* Create 'Unable To Decrypt' grid layout for hidden events on a bubble layout ([\element-hq#8704](matrix-org/matrix-react-sdk#8704)). Fixes element-hq#22365. Contributed by @luixxiul.
* Fix - AccessibleButton does not set disabled attribute ([\element-hq#8682](matrix-org/matrix-react-sdk#8682)). Contributed by @kerryarchibald.
* Fix font not resetting when logging out ([\element-hq#8670](matrix-org/matrix-react-sdk#8670)). Fixes element-hq#17228.
* Fix local aliases section of room settings not working for some homeservers (ie ([\element-hq#8698](matrix-org/matrix-react-sdk#8698)). Fixes element-hq#22337.
* Align EventTile_line with display name on message bubble ([\element-hq#8692](matrix-org/matrix-react-sdk#8692)). Fixes element-hq#22343. Contributed by @luixxiul.
* Convert references to direct chat -> direct message ([\element-hq#8694](matrix-org/matrix-react-sdk#8694)). Contributed by @novocaine.
* Improve combining diacritics for U+20D0 to U+20F0 in Chrome ([\element-hq#8687](matrix-org/matrix-react-sdk#8687)).
* Make the empty thread panel fill BaseCard ([\element-hq#8690](matrix-org/matrix-react-sdk#8690)). Fixes element-hq#22338. Contributed by @luixxiul.
* Fix edge case around composer handling gendered facepalm emoji ([\element-hq#8686](matrix-org/matrix-react-sdk#8686)).
* Fix a grid blowout due to nowrap displayName on a bubble with UTD ([\element-hq#8688](matrix-org/matrix-react-sdk#8688)). Fixes element-hq#21914. Contributed by @luixxiul.
* Apply the same max-width to image tile on the thread timeline as message bubble ([\element-hq#8669](matrix-org/matrix-react-sdk#8669)). Fixes element-hq#22313. Contributed by @luixxiul.
* Fix dropdown button size for picture-in-picture CallView ([\element-hq#8680](matrix-org/matrix-react-sdk#8680)). Fixes element-hq#22316. Contributed by @luixxiul.
* Live location sharing - fix square border for image-less avatar (PSF-1052) ([\element-hq#8679](matrix-org/matrix-react-sdk#8679)). Contributed by @kerryarchibald.
* Stop connecting to a video room if the widget messaging disappears ([\element-hq#8660](matrix-org/matrix-react-sdk#8660)).
* Fix file button and audio player overflowing from message bubble ([\element-hq#8666](matrix-org/matrix-react-sdk#8666)). Fixes element-hq#22308. Contributed by @luixxiul.
* Don't show broken composer format bar when selection is whitespace ([\element-hq#8673](matrix-org/matrix-react-sdk#8673)). Fixes element-hq#10788.
* Fix media upload http 413 handling ([\element-hq#8674](matrix-org/matrix-react-sdk#8674)).
* Fix emoji picker for editing thread responses ([\element-hq#8671](matrix-org/matrix-react-sdk#8671)). Fixes matrix-org/element-web-rageshakes#13129.
* Map attribution while sharing live location is now visible ([\element-hq#8621](matrix-org/matrix-react-sdk#8621)). Fixes element-hq#22236. Contributed by @weeman1337.
* Fix info tile overlapping the time stamp on TimelineCard ([\element-hq#8639](matrix-org/matrix-react-sdk#8639)). Fixes element-hq#22256. Contributed by @luixxiul.
* Fix position of wide images on IRC / modern layout ([\element-hq#8667](matrix-org/matrix-react-sdk#8667)). Fixes element-hq#22309. Contributed by @luixxiul.
* Fix other user's displayName being wrapped on the bubble message layout ([\element-hq#8456](matrix-org/matrix-react-sdk#8456)). Fixes element-hq#22004. Contributed by @luixxiul.
* Set spacing declarations to elements in mx_EventTile_mediaLine ([\element-hq#8665](matrix-org/matrix-react-sdk#8665)). Fixes element-hq#22307. Contributed by @luixxiul.
* Fix wide image overflowing from the thumbnail container ([\element-hq#8663](matrix-org/matrix-react-sdk#8663)). Fixes element-hq#22303. Contributed by @luixxiul.
* Fix styles of "Show all" link button on ReactionsRow ([\element-hq#8658](matrix-org/matrix-react-sdk#8658)). Fixes element-hq#22300. Contributed by @luixxiul.
* Automatically log in after registration ([\element-hq#8654](matrix-org/matrix-react-sdk#8654)). Fixes element-hq#19305. Contributed by @justjanne.
* Fix offline status in window title not working reliably ([\element-hq#8656](matrix-org/matrix-react-sdk#8656)).
* Align input area with event body's first letter in a thread on IRC/modern layout ([\element-hq#8636](matrix-org/matrix-react-sdk#8636)). Fixes element-hq#22252. Contributed by @luixxiul.
* Fix crash on null idp for SSO buttons ([\element-hq#8650](matrix-org/matrix-react-sdk#8650)). Contributed by @hughns.
* Don't open the regular browser or our context menu on right-clicking the `Options` button in the message action bar ([\element-hq#8648](matrix-org/matrix-react-sdk#8648)). Fixes element-hq#22279.
* Show notifications even when Element is focused ([\element-hq#8590](matrix-org/matrix-react-sdk#8590)). Contributed by @sumnerevans.
* Remove padding from the buttons on edit message composer of a event tile on a thread ([\element-hq#8632](matrix-org/matrix-react-sdk#8632)). Contributed by @luixxiul.
* ensure metaspace changes correctly notify listeners ([\element-hq#8611](matrix-org/matrix-react-sdk#8611)). Fixes element-hq#21006. Contributed by @justjanne.
* Hide image banner on stickers, they have a tooltip already ([\element-hq#8641](matrix-org/matrix-react-sdk#8641)). Fixes element-hq#22244.
* Adjust EditMessageComposer style declarations ([\element-hq#8631](matrix-org/matrix-react-sdk#8631)). Fixes element-hq#22231. Contributed by @luixxiul.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Read-Marker Green line showing how far _you_ have read P1 T-Enhancement Z-Community-PR Issue is solved by a community member's PR Z-Mozilla
Projects
None yet
Development

Successfully merging a pull request may close this issue.